Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubSub: Add system tests for PubSub clients #8277

Merged
merged 6 commits into from
Jun 21, 2019
Merged

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jun 11, 2019

Closes #4031.

The title says it all - this PR adds the missing system tests mentioned in the issue description:

  • Listing topics and subscriptions in the client's project.
  • Creating subscriptions with non-default settings.
  • Listing subscriptions bound to a topic.
  • Setting / getting IAM policy for topics and subscriptions
  • Creating / seeking snapshots. ⬅️ Removed, because the server only guarantees eventual re-delivery, and a test cannot wait for a fixed amount of time, causes flakiness.

@plamut plamut added the api: pubsub Issues related to the Pub/Sub API. label Jun 11, 2019
@plamut plamut requested a review from anguillanneuf as a code owner June 11, 2019 08:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2019
pubsub/tests/system.py Outdated Show resolved Hide resolved
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 18, 2019
plamut added 6 commits June 20, 2019 15:32
The PubSub backend does not give any guarantees about when a message
will be re-delivered after seeking back to a snapshot, it will only
be delivered "eventually". That causes flakiness in the snapshots
test.

Since the test cannot wait for an indefinite amount of time, this
commit removes it in order to not randomly break the CI builds.
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@plamut plamut merged commit ac31bcf into googleapis:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing system tests after pubsub redesign
5 participants