-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate grafeas and container analysis. #8186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
May 28, 2019
busunkim96
force-pushed
the
generate-grafeas
branch
from
June 5, 2019 20:01
5509ace
to
c77fc10
Compare
busunkim96
force-pushed
the
generate-grafeas
branch
from
June 6, 2019 19:52
266b2d4
to
cefd269
Compare
busunkim96
force-pushed
the
generate-grafeas
branch
2 times, most recently
from
June 11, 2019 21:01
cf2832a
to
7acfa82
Compare
crwilcox
approved these changes
Jun 17, 2019
|
||
# General information about the project. | ||
project = u"google-cloud-containeranalysis" | ||
copyright = u"2017, Google" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be out of scope for this generation, but should this be 2019 seeing as these are new apis?
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the generation for Grafeas + Container Analysis.
We are creating separate clients (Grafeas is the open source version, Container Analysis is Google specific). Container Analysis will have a dependency GrafeasClient, and there will be an easy way of getting a GrafeasClient instance from a ContainerAnalysisClient.
I would appreciate it if you could particularly look at this diff where the following things were removed:
prototype in C#
Will do these two things once an initial version of ContainerAnalysis and Grafeas have been published. (not in this PR) :)