Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate grafeas and container analysis. #8186

Merged
merged 18 commits into from
Jun 17, 2019

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented May 28, 2019

This is the generation for Grafeas + Container Analysis.

We are creating separate clients (Grafeas is the open source version, Container Analysis is Google specific). Container Analysis will have a dependency GrafeasClient, and there will be an easy way of getting a GrafeasClient instance from a ContainerAnalysisClient.

I would appreciate it if you could particularly look at this diff where the following things were removed:

  • default API Endpoint
  • default credentials (require a transport to initialize the client)
  • default oauth scopes.

prototype in C#

  • Generate the regular GAPIC library for Grafeas
  • Remove any sign of a default endpoint or use of default application credentials
  • Generate a GAPIC library for Container Analysis, that only contains the IAM methods already present in the service

Will do these two things once an initial version of ContainerAnalysis and Grafeas have been published. (not in this PR) :)

  • Make the ContainerAnalysis library depend on the Grafeas library
  • Add a property to ContainerAnalysisClient to get a GrafeasClient with the same gRPC channel (so endpoint and credentials)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 28, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 4, 2019
@busunkim96 busunkim96 changed the title Generate grafeas. Generate grafeas and container analysis. Jun 6, 2019
@busunkim96 busunkim96 removed the 🚨 This issue needs some love. label Jun 6, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 6, 2019
@busunkim96 busunkim96 marked this pull request as ready for review June 6, 2019 16:56
@busunkim96 busunkim96 requested a review from crwilcox June 6, 2019 23:55
@busunkim96 busunkim96 force-pushed the generate-grafeas branch 2 times, most recently from cf2832a to 7acfa82 Compare June 11, 2019 21:01

# General information about the project.
project = u"google-cloud-containeranalysis"
copyright = u"2017, Google"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be out of scope for this generation, but should this be 2019 seeing as these are new apis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants