Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: Raise ValueError when BQ Storage is required but missing #7726

Merged
merged 1 commit into from
Apr 19, 2019
Merged

BigQuery: Raise ValueError when BQ Storage is required but missing #7726

merged 1 commit into from
Apr 19, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Apr 18, 2019 •
edited
Loading

Move the BigQuery Storage API optional dependency imports to the top of
the module, following the existing pattern for other optional
dependencies.

@tswast
Raise ValueError when BQ Storage is required but missing
55d7dc6 
Move the BigQuery Storage API optional dependency imports to the top of
the module, following the existing pattern for other optional
dependencies.
@tswast tswast added api: bigquery Issues related to the BigQuery API. api: bigquerystorage Issues related to the BigQuery Storage API. labels Apr 18, 2019
@tswast tswast requested a review from crwilcox as a code owner April 18, 2019 00:02
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 18, 2019
@tswast tswast requested review from shollyman and plamut April 18, 2019 00:04
@tswast tswast mentioned this pull request Apr 18, 2019
Merged
shollyman
shollyman approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional imports still wierd me out. If we get more of these I wonder if there should be some kind of annotation on methods rather than these variable tests, but this seems fine.

@tswast tswast merged commit 8faa54d into googleapis:master Apr 19, 2019
@tswast tswast deleted the bqstorage-import-error branch April 19, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@plamut plamut Awaiting requested review from plamut

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. api: bigquerystorage Issues related to the BigQuery Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @shollyman @googlebot