Add page iterator to ReadRowsStream #7680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tswast
force-pushed
the
bqstorage-rowiterator
branch
2 times, most recently
from
f7bce5b
to
df5500e
Compare
tswast
changed the title
This was referenced Apr 12, 2019
shollyman
approved these changes
Apr 16, 2019
| ] | ||
| avro_schema = _bq_to_avro_schema(bq_columns) | ||
| read_session = _generate_read_session(avro_schema) | ||
| bq_blocks_1 = [ |
There was a problem hiding this comment.
Minor nit: the naming of the "blocks" variables reads oddly to me. You're testing a single block with multiple rows, not multiple blocks. It's consistent with existing tests, just seems odd.
There was a problem hiding this comment.
Actually, this does contain 2 blocks. black just formatted it in such a way that it's not clear.
I've separated each block into its own variable and added a comment for why there are two groups of blocks. Hopefully this makes it clearer.
This allows readers to read blocks (called pages for compatibility with BigQuery client library) one at a time from a stream. This enables use cases such as progress bar support and streaming workers that expect pandas DataFrames.
tswast
force-pushed
the
bqstorage-rowiterator
branch
from
5bbaaf6
to
222d413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows readers to read blocks (called pages for compatibility with
BigQuery client library) one at a time from a stream. This enables use
cases such as progress bar support and streaming workers that expect
pandas DataFrames.
Towards #7654