Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gRPC size limit for bigquery storage #7664

Merged
merged 2 commits into from
Apr 8, 2019
Merged

remove gRPC size limit for bigquery storage #7664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6c8ada
remove gRPC size limit for bigquery storage
MartinNowak Apr 5, 2019
a4f9ea3
Add message lenght override to synth config.
tswast Apr 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...oogle/cloud/bigquery_storage_v1beta1/gapic/transports/big_query_storage_grpc_transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,13 @@ def create_channel(
grpc.Channel: A gRPC channel object.
"""
return google.api_core.grpc_helpers.create_channel( # pragma: no cover
address, credentials=credentials, scopes=cls._OAUTH_SCOPES
address,
credentials=credentials,
scopes=cls._OAUTH_SCOPES,
options={
"grpc.max_send_message_length": -1,
"grpc.max_receive_message_length": -1,
}.items(),
)

@property
Expand Down
11 changes: 11 additions & 0 deletions bigquery_storage/synth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,17 @@
"big_query_storage_client.BigQueryStorageClient",
)

# The grpc transport channel shouldn't limit the size of a grpc message at the
# default 4mb.
s.replace("google/cloud/bigquery_storage_v1beta1/gapic/transports/*_grpc_transport.py",
"return google.api_core.grpc_helpers.create_channel\(\n(\s+)address,\n"
"\s+credentials=.*,\n\s+scopes=.*,\n",
"\g<0>\g<1>options={\n"
"\g<1> 'grpc.max_send_message_length': -1,\n"
"\g<1> 'grpc.max_receive_message_length': -1,\n"
"\g<1>}.items(),\n",
)

# START: Ignore lint and coverage
s.replace(
["google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py"],
Expand Down