-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using a fallback connection in Bucket #759
Conversation
@@ -143,6 +135,9 @@ def create_bucket(bucket_name, project=None, connection=None): | |||
|
|||
This implements "storage.buckets.insert". | |||
|
|||
If the bucket already exists, will raise | |||
:class:`gcloud.exceptions.Conflict`. | |||
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
69c321f
to
f19effa
Compare
f19effa
to
adc470b
Compare
After discussing with @tseaver it has been determined that unbundling |
This is an alternative fix to #728, by way of making
connection
be optional.This has an effect of cascading through everything since
ACL
andBlob
both use the connection of theBucket
.Note especially the changes to
get_bucket
andcreate_bucket
, which passesNone
through to theBucket()
constructor and lets the environment dictate the connection (e.g. in a batch).@tseaver Do you think
bucket.connection
being a non-deterministic value will be confounding?