-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove classifier for Python 3.4 for end-of-life. #7535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Mar 19, 2019
We aren't likely to make changes which break 3.4 before we also drop 2.7 support:
|
tseaver
approved these changes
Mar 19, 2019
@tseaver we are 100% on the same page on this one. If we batch it with 2.7 it will save a major bump and be less disruptive. |
tswast
approved these changes
Mar 19, 2019
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Jun 4, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Aug 15, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
parthea
pushed a commit
that referenced
this pull request
Oct 31, 2023
* Remove classifier for Python 3.4 for end-of-life. * Update supported versions in Client README, Contributing Guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.4 has reached EOL. https://www.python.org/dev/peps/pep-0429/
At this point we should remove the classifier for 3.4 and discourage its use. This change doesn't prevent users from installing this library on 3.4. Doing so would require rev-ing versions of our libraries and create a good deal of noise. My suggestion is that we modify
python_requires
as other breaking changes come, removing 3.4 at that point.