Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: harden 'ArrayQueryParameter.from_api_repr' against missing 'parameterValue'. #7311

Merged
merged 1 commit into from
Feb 12, 2019
Merged

BigQuery: harden 'ArrayQueryParameter.from_api_repr' against missing 'parameterValue'. #7311

merged 1 commit into from
Feb 12, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Feb 12, 2019

Closes #7309.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Feb 12, 2019
@tseaver tseaver requested a review from tswast February 12, 2019 18:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2019
@tswast
Copy link
Contributor

tswast commented Feb 12, 2019

Test failure is due to a problem with the GitHub public dataset. Tracked internally at bug 124196028.

@tseaver tseaver merged commit b360a63 into googleapis:master Feb 12, 2019
@tseaver tseaver deleted the 7309-bigquery-query_job_config-fix_empty_array_params branch February 12, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @tswast @googlebot