Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container: remove unused message exports (via synth). #7265

Closed
wants to merge 1 commit into from

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/container/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:75bc07ef34a1de9895c18af54dc503ed3b3f3b52e85062e3360a979d2a0741e7
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/container/artman_container_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/container-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/container/v1/cluster_service.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/container-v1/google/cloud/container_v1/proto/cluster_service.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/container-v1/google/cloud/container_v1/proto.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/container_v1/proto/cluster_service_pb2.py.
synthtool > Replaced 'nodePool>\\n' in google/cloud/container_v1/proto/cluster_service_pb2.py.
synthtool > Replaced '(\\s+)`__ instead' in google/cloud/container_v1/proto/cluster_service_pb2.py.
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtualenv using python3.6 in /tmpfs/src/git/autosynth/working_repo/container/.nox/blacken
pip install --upgrade black
black google tests docs
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/gapic/transports/cluster_manager_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/gapic/cluster_manager_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/proto/cluster_service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/gapic/cluster_manager_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/tests/unit/gapic/v1/test_cluster_manager_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/proto/cluster_service_pb2.py
All done! ✨ 🍰 ✨
9 files reformatted, 8 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: container Issues related to the Kubernetes Engine API API. label Feb 2, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2019
@tseaver tseaver added the codegen label Feb 4, 2019
@tseaver tseaver changed the title [CHANGE ME] Re-generated container to pick up changes in the API or client library generator. Container: remove unused message exports (via synth). Feb 4, 2019
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@tseaver
Copy link
Contributor

tseaver commented Feb 7, 2019

@tseaver
Copy link
Contributor

tseaver commented Feb 7, 2019

Container test failures are troubling:

unning session unit-2.7
Creating virtualenv using python2.7 in /tmpfs/src/github/google-cloud-python/container/.nox/unit-2-7
pip install --upgrade mock pytest pytest-cov
pip install --upgrade -e ../api_core
pip install --upgrade -e ../core
pip install --upgrade -e .
py.test --quiet --cov=google.cloud --cov=tests.unit --cov-append --cov-config=.coveragerc --cov-report= --cov-fail-under=76 tests/unit
............................................................             [100%]Coverage.py warning: Module tests.unit was never imported. (module-not-imported)
Required test coverage of 76% reached. Total coverage: 100.00%
60 passed in 0.81 seconds
Session unit-2.7 was successful.
Running session unit-3.5
Creating virtualenv using python3.5 in /tmpfs/src/github/google-cloud-python/container/.nox/unit-3-5
pip install --upgrade mock pytest pytest-cov
pip install --upgrade -e ../api_core
pip install --upgrade -e ../core
pip install --upgrade -e .
py.test --quiet --cov=google.cloud --cov=tests.unit --cov-append --cov-config=.coveragerc --cov-report= --cov-fail-under=76 tests/unit
............................................................             [100%]Coverage.py warning: Module google.cloud was previously imported, but not measured (module-not-measured)
Coverage.py warning: Module tests.unit was never imported. (module-not-imported)
FAIL Required test coverage of 76% not reached. Total coverage: 75.56%

I cannot reproduce on my local machine, although I do see the coverage warnings during the unit test runs, and the same missing coverage lines in google/cloud/__init__.py and google/cloud/container.py.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 9, 2019
@tseaver
Copy link
Contributor

tseaver commented Feb 19, 2019

Unrelated test failures (shouldn't have run, karthago delenda est):

@tseaver
Copy link
Contributor

tseaver commented Feb 19, 2019

As with #7262 and #7263, the coverage-related failures here are mysterious.

@tseaver tseaver added needs work This is a pull request that needs a little love. and removed 🚨 This issue needs some love. labels Feb 19, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 3, 2019
@busunkim96
Copy link
Contributor

Closing this to force a regen.

@busunkim96 busunkim96 closed this May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: container Issues related to the Kubernetes Engine API API. cla: yes This human has signed the Contributor License Agreement. codegen needs work This is a pull request that needs a little love. 🚨 This issue needs some love.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants