Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] AutoML: minor gapic generator changes #7224

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] AutoML: minor gapic generator changes #7224

wants to merge 1 commit into from

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/automl/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:d6c8ced606eb49973ca95d2af7c55a681acc042db0f87d135968349e7bf6dd80
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/automl/artman_automl_v1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1.
synthtool > Replaced 'metadata_type=operations_pb2.OperationMetadata' in google/cloud/automl_v1beta1/gapic/auto_ml_client.py.
synthtool > No replacements made in google/cloud/automl_v1beta1/gapic/prediction_service_client.py for pattern ^\s+::, maybe replacement is not longer needed?
synthtool > No replacements made in google/cloud/automl_v1beta1/gapic/auto_ml_client.py for pattern ^(\s+)(::)

\s+?([^\s]), maybe replacement is not longer needed?
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtualenv using python3.6 in /tmpfs/src/git/autosynth/working_repo/automl/.nox/blacken
pip install --upgrade black
black google tests docs
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/prediction_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/transports/auto_ml_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/prediction_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/transports/prediction_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/annotation_payload_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/auto_ml_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/classification_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/annotation_payload_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/data_items_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/data_items_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/dataset_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/auto_ml_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/image_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/classification_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/io_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/dataset_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/model_evaluation_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/image_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/model_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/io_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/operations_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/model_evaluation_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/prediction_service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/operations_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/model_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/text_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/text_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/translation_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/prediction_service_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/tests/unit/gapic/v1beta1/test_prediction_service_client_v1beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/translation_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/tests/unit/gapic/v1beta1/test_auto_ml_client_v1beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/service_pb2.py
All done! ✨ 🍰 ✨
38 files reformatted, 6 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: automl Issues related to the AutoML API. label Jan 30, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2019
@tseaver tseaver changed the title [CHANGE ME] Re-generated automl to pick up changes in the API or client library generator. [DO NOT MERGE] AutoML: minor gapic generator changes Jan 30, 2019
tseaver
tseaver reviewed Jan 30, 2019
View reviewed changes
automl/google/cloud/automl_v1beta1/__init__.py
enums = enums


__all__ = ("enums", "types", "PredictionServiceClient", "AutoMlClient")
__all__ = ("enums", "types", "AutoMlClient", "PredictionServiceClient")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the generator has decided to sort the wrapper classes?

automl/google/cloud/automl_v1beta1/gapic/auto_ml_client.py
from google.cloud.automl_v1beta1.proto import dataset_pb2
from google.cloud.automl_v1beta1.proto import io_pb2
from google.cloud.automl_v1beta1.proto import model_evaluation_pb2
from google.cloud.automl_v1beta1.proto import model_pb2
from google.cloud.automl_v1beta1.proto import operations_pb2 as proto_operations_pb2
from google.cloud.automl_v1beta1.proto import prediction_service_pb2
from google.cloud.automl_v1beta1.proto import prediction_service_pb2_grpc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird -- if those imports weren't being used, why did our linting not fail before?

automl/google/cloud/automl_v1beta1/gapic/prediction_service_client.py
from google.cloud.automl_v1beta1.proto import service_pb2
from google.cloud.automl_v1beta1.proto import service_pb2_grpc
from google.longrunning import operations_pb2 as longrunning_operations_pb2
from google.protobuf import empty_pb2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be right -- non of these imports are used.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 30, 2019
@crwilcox crwilcox closed this Feb 1, 2019
@crwilcox crwilcox deleted the autosynth-automl branch February 1, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: automl Issues related to the AutoML API. cla: yes This human has signed the Contributor License Agreement. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshi-automation @tseaver @crwilcox @googlebot