Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bigquery_storage to docs #7222

Merged
merged 5 commits into from
Jan 30, 2019
Merged

Add bigquery_storage to docs #7222

merged 5 commits into from
Jan 30, 2019

Conversation

busunkim96
Copy link
Contributor

No description provided.

@busunkim96 busunkim96 requested a review from tseaver January 29, 2019 22:49
@busunkim96 busunkim96 requested a review from crwilcox as a code owner January 29, 2019 22:49
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 29, 2019
@busunkim96 busunkim96 added type: docs Improvement to the documentation for an API. api: bigquerystorage Issues related to the BigQuery Storage API. labels Jan 29, 2019
@busunkim96
Copy link
Contributor Author

@tswast Could you also take a look at this?

tswast
tswast reviewed Jan 30, 2019
View reviewed changes
bigquery_storage/noxfile.py Outdated


@nox.session(python='3.6')
def docs(session):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it handy to have this so that I don't have to build everything when I just want to see a single library's docs. Do we have to delete it?

tswast
tswast approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@busunkim96 busunkim96 merged commit 5183966 into googleapis:master Jan 30, 2019
@busunkim96 busunkim96 deleted the bigquery_storage_docs branch January 30, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the BigQuery Storage API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@busunkim96 @tseaver @tswast @googlebot