Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubsub: Initialize 'StreamingPullFuture._cancelled' as True #6901

Merged
merged 4 commits into from
Dec 12, 2018
Merged

Pubsub: Initialize 'StreamingPullFuture._cancelled' as True #6901

merged 4 commits into from
Dec 12, 2018

Conversation

brunoais
Copy link
Contributor

No description provided.

@brunoais brunoais requested a review from crwilcox as a code owner December 11, 2018 16:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2018
@tseaver tseaver changed the title [bugfix] StreamingPullFuture __init__ had _cancelled = True Pubsub: Initialize 'StreamingPullFuture._cancelled' as True Dec 11, 2018
tseaver
tseaver suggested changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch! Can you please add assertions to the two constructor tests 1 2 asserting that future._cancelled is False?

@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Dec 11, 2018
@brunoais
Copy link
Contributor Author

I may but later today.

@brunoais
Copy link
Contributor Author

@tseaver done adding

tseaver
tseaver previously approved these changes Dec 11, 2018
View reviewed changes
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 11, 2018
@tseaver
Copy link
Contributor

tseaver commented Dec 11, 2018

@brunoais Thanks again! I will merge when CI is green.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 11, 2018
@tseaver tseaver dismissed their stale review December 11, 2018 21:40

Test in wrong location.

@tseaver
Copy link
Contributor

tseaver commented Dec 11, 2018

@brunoais My apologies -- I didn't look closely enough, and asked you to add assertions to the wrong testcase file. Can you please rebase out the second commit and add an assertion here instead?

@tseaver
Remove ill-directed assertions.
0501c10 
I wrongly asked that they be added in this file, rather than in `pubsub/tests/unit/pubsub_v1/subscriber/test_futures_subscriber.py`
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 12, 2018
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 12, 2018
@crwilcox crwilcox added the cla: yes This human has signed the Contributor License Agreement. label Dec 12, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Dec 12, 2018
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 12, 2018
@tseaver tseaver merged commit 2a6b38e into googleapis:master Dec 12, 2018
@brunoais
Copy link
Contributor Author

@tseaver Thank you for doing the commits for me. I was unavailable until now.
Is it all alright now with your corrections?

@tseaver
Copy link
Contributor

tseaver commented Dec 12, 2018

@brunoais Thanks again for the patch, and sorry for the trouble about the tests.

@brunoais
Copy link
Contributor Author

No worries.

@brunoais brunoais deleted the patch-1 branch December 12, 2018 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brunoais @tseaver @googlebot @crwilcox @yoshi-kokoro