Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery Storage: pick up fixes in GAPIC generator. #6708

Merged
merged 1 commit into from
Nov 30, 2018
Merged

BigQuery Storage: pick up fixes in GAPIC generator. #6708

merged 1 commit into from
Nov 30, 2018

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > You are running the synthesis script directly, this will be disabled in a future release of Synthtool. Please use python3 -m synthtool instead.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:2f6b261ee7fe1aedf238991c93a20b3820de37a343d0cacf3e3e9555c2aaf2ea
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/bigquery/storage/artman_bigquerystorage_v1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerystorage-v1beta1.
synthtool > Replaced 'from google.cloud.bigquery.storage_v1beta1.proto' in google/cloud/bigquery_storage_v1beta1/proto/storage_pb2.py.
synthtool > Replaced 'from google.cloud.bigquery.storage_v1beta1.proto' in google/cloud/bigquery_storage_v1beta1/proto/storage_pb2_grpc.py.
synthtool > Replaced 'google-cloud-bigquerystorage' in google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py.
synthtool > Replaced 'import google.api_core.gapic_v1.method\n' in google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py.
synthtool > Replaced 'from google.cloud import bigquery_storage_v1beta1' in tests/unit/gapic/v1beta1/test_big_query_storage_client_v1beta1.py.
synthtool > Replaced 'bigquery_storage_v1beta1.BigQueryStorageClient' in tests/unit/gapic/v1beta1/test_big_query_storage_client_v1beta1.py.
synthtool > Replaced 'if transport:' in google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py.
synthtool > Replaced 'to_grpc_metadata\\(\\n' in google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py.
synthtool > Replaced 'metadata.append\\(routing_metadata\\)' in google/cloud/bigquery_storage_v1beta1/gapic/big_query_storage_client.py.
synthtool > Replaced 'if channel is not None and credentials is not None:' in google/cloud/bigquery_storage_v1beta1/gapic/transports/big_query_storage_grpc_transport.py.
synthtool > Replaced 'if channel is None:' in google/cloud/bigquery_storage_v1beta1/gapic/transports/big_query_storage_grpc_transport.py.
synthtool > Replaced 'google.api_core.grpc_helpers.create_channel\\(' in google/cloud/bigquery_storage_v1beta1/gapic/transports/big_query_storage_grpc_transport.py.
synthtool > Cleaned up 0 temporary directories.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 29, 2018
@tseaver tseaver changed the title [CHANGE ME] Re-generated bigquery_storage to pick up changes in the API or client library generator. BigQuery Storage: pick up fixes in GAPIC generator. Nov 30, 2018
tseaver
tseaver approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Includes fixes from these gapic-generator PRs:

@tseaver tseaver added codegen kokoro:force-run Add this label to force Kokoro to re-run the tests. api: bigquerystorage Issues related to the BigQuery Storage API. labels Nov 30, 2018
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2018
@tseaver
Copy link
Contributor

tseaver commented Nov 30, 2018 •
edited
Loading

System tests fail with the message:

PermissionDenied: 403 BigQuery Storage API has not been used in project #### before or it is disabled.

When I checked just now, the API was enabled for our CI project. I am re-running the tests.

@tseaver
Copy link
Contributor

tseaver commented Nov 30, 2018

System tests pass locally.

@tseaver tseaver merged commit 9d88a03 into master Nov 30, 2018
@tseaver tseaver deleted the autosynth-bigquery_storage branch November 30, 2018 16:35
erikwebb pushed a commit to erikwebb/google-cloud-python that referenced this pull request Dec 3, 2018
@yoshi-automation
Pick up fixes in GAPIC generator. (googleapis#6708)
d44fd09 

Includes fixes from these gapic-generator PRs:

- googleapis/gapic-generator#2407
- googleapis/gapic-generator#2396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the BigQuery Storage API. cla: yes This human has signed the Contributor License Agreement. codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yoshi-automation @tseaver @googlebot @yoshi-kokoro