Code

Firestore: add Watch Support#6191

Code

Merged

crwilcox merged 164 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom crwilcox:firestore-watchcrwilcox/google-cloud-python:firestore-watchCopy head branch name to clipboardNov 12, 2018

+2,497-5

Commits

Commits on Jun 12, 2018

• groundwork for firestore

  crwilcox

  committed
  4c51dac

  Copy full SHA for 4c51dac

Commits on Jun 18, 2018

• Use chemelnucfin sample (pythonification of nodejs) as base

  crwilcox

  committed
  972b62f

  Copy full SHA for 972b62f

• syntactic and style fixes

  crwilcox

  committed
  a66ce73

  Copy full SHA for a66ce73

Commits on Jun 27, 2018

• Merge branch 'master' of github.com:GoogleCloudPlatform/google-cloud-python into firestore-watch

  crwilcox

  committed
  b06c55b

  Copy full SHA for b06c55b

• hold work

  crwilcox

  committed
  1390eb8

  Copy full SHA for 1390eb8

• use helper for_document

  crwilcox

  committed
  45f48d6

  Copy full SHA for 45f48d6

Commits on Jul 3, 2018

• Staging changes to firestore for watch. still incomplete but returning document changes

  crwilcox

  committed
  4758b6b

  Copy full SHA for 4758b6b

Commits on Jul 10, 2018

• returning watch result now

  crwilcox

  committed
  ff7aad7

  Copy full SHA for ff7aad7

• broken currently, but nearing handling of multiple documents in collection

  crwilcox

  committed
  c597669

  Copy full SHA for c597669

Commits on Jul 11, 2018

• small fixes. seems mostly working

  crwilcox

  committed
  048b5fa

  Copy full SHA for 048b5fa

• fix variable name, remove things from doc map on remove

  crwilcox

  committed
  a2fdd18

  Copy full SHA for a2fdd18

Commits on Aug 14, 2018

• merge crwilcox firestore-watch branch into a recent branch from master

  mcdonc

  committed
  421b841

  Copy full SHA for 421b841

• improve doc strings and comment out yet to be done methods

  crwilcox

  committed
  6a0294e

  Copy full SHA for 6a0294e

• remove fstrings for 2.7 compat

  mcdonc

  committed
  fd889d5

  Copy full SHA for fd889d5

• be more specific on snapshot type

  crwilcox

  committed
  83755b8

  Copy full SHA for 83755b8

• Merge remote-tracking branch 'crwilcox/firestore-watch' into firestore-watch

  mcdonc

  committed
  eb8a48c

  Copy full SHA for eb8a48c

Commits on Aug 20, 2018

• unit tests for watch module

  mcdonc

  committed
  a327dfe

  Copy full SHA for a327dfe

• these must be staticmethods; improve performance in _affects_target

  mcdonc

  committed
  a26699d

  Copy full SHA for a26699d

• make system test for watch pass

  mcdonc

  committed
  cf85c92

  Copy full SHA for cf85c92

• containment check instead of iteration

  mcdonc

  committed
  9b0a4c2

  Copy full SHA for 9b0a4c2

• fix filter update test

  mcdonc

  committed
  5bd6374

  Copy full SHA for 5bd6374

Commits on Aug 21, 2018

• tests for various helper methods

  mcdonc

  committed
  481ae83

  Copy full SHA for 481ae83

• Improve rpc_done and add early query support

  crwilcox

  committed
  a5c78a2

  Copy full SHA for a5c78a2

• Merge branch 'firestore-watch' of github.com:mcdonc/google-cloud-python into firestore-watch

  crwilcox

  committed
  4ce2939

  Copy full SHA for 4ce2939

• add more tests

  mcdonc

  committed
  4301130

  Copy full SHA for 4301130

• Merge remote-tracking branch 'crwilcox/firestore-watch' into firestore-watch

  mcdonc

  committed
  e00884b

  Copy full SHA for e00884b

• add tests for close

  mcdonc

  committed
  623e635

  Copy full SHA for 623e635

• not reraising in except broke tests

  mcdonc

  committed
  27de7be

  Copy full SHA for 27de7be

• compute_snapshot_ordering test still fails but fails later than it used to

  mcdonc

  committed
  c665d73

  Copy full SHA for c665d73

• remove incorrect comment

  mcdonc

  committed
  86628fd

  Copy full SHA for 86628fd

• parent is a fq path

  crwilcox

  committed
  23eaad5

  Copy full SHA for 23eaad5

• Merge branch 'firestore-watch' of github.com:mcdonc/google-cloud-python into firestore-watch

  crwilcox

  committed
  065e988

  Copy full SHA for 065e988

• Merge remote-tracking branch 'crwilcox/firestore-watch' into firestore-watch

  mcdonc

  committed
  9db3d18

  Copy full SHA for 9db3d18

• fix and add test for _reset_docs

  mcdonc

  committed
  0d9de3c

  Copy full SHA for 0d9de3c

• Merge branch 'firestore-watch' of github.com:mcdonc/google-cloud-python into firestore-watch

  crwilcox

  committed
  199aaf1

  Copy full SHA for 199aaf1

Commits on Aug 22, 2018

• undo mistaken push

  mcdonc

  committed
  2a0723a

  Copy full SHA for 2a0723a

• Merge remote-tracking branch 'crwilcox/firestore-watch' into firestore-watch

  mcdonc

  committed
  f2b7c13

  Copy full SHA for f2b7c13

• appease the linter

  mcdonc

  committed
  889f350

  Copy full SHA for 889f350

• idiom

  mcdonc

  committed
  698e512

  Copy full SHA for 698e512

• enable collection watches

  crwilcox

  committed
  3a70102

  Copy full SHA for 3a70102

• Merge branch 'firestore-watch' of github.com:mcdonc/google-cloud-python into firestore-watch

  crwilcox

  committed
  ed329dd

  Copy full SHA for ed329dd

• undo spurious changes

  mcdonc

  committed
  2301a0e

  Copy full SHA for 2301a0e

• add unfinished test

  mcdonc

  committed
  cca772e

  Copy full SHA for cca772e

Commits on Aug 23, 2018

• modify the way we compute document references to support query and collection watches

  crwilcox

  committed
  48fac6d

  Copy full SHA for 48fac6d

Commits on Aug 24, 2018

• add system tests for each variety of watch

  crwilcox

  committed
  66b6071

  Copy full SHA for 66b6071

• fix most unit tests, 3 still fail

  mcdonc

  committed
  67a609f

  Copy full SHA for 67a609f

• merge and apply

  crwilcox

  committed
  d598f32

  Copy full SHA for d598f32

• expected time of test was not the same as read time, so false failure

  crwilcox

  committed
  c6ae725

  Copy full SHA for c6ae725

• tests passing

  crwilcox

  committed
  87ccc87

  Copy full SHA for 87ccc87

Commits on Aug 25, 2018

• make the datetime.datetime returned non-naive and assume it's in UTC

  mcdonc

  committed
  725f4a4

  Copy full SHA for 725f4a4

• depends directly on pytz now

  mcdonc

  committed
  ee12608

  Copy full SHA for ee12608

Commits on Aug 28, 2018

• 100pct statement coverage for watch and test_watch

  mcdonc

  committed
  6aac664

  Copy full SHA for 6aac664

• just cutnpaste this i guess

  mcdonc

  committed
  97368c9

  Copy full SHA for 97368c9

• coverage for collection and bidi modules

  mcdonc

  committed
  53d6745

  Copy full SHA for 53d6745

• coverage for document and query methods added

  mcdonc

  committed
  1e73ab7

  Copy full SHA for 1e73ab7

Commits on Aug 29, 2018

• 100 percent branch coverage

  mcdonc

  committed
  6ade323

  Copy full SHA for 6ade323

• appease linter

  mcdonc

  committed
  2ee71fe

  Copy full SHA for 2ee71fe

Commits on Sep 19, 2018

• should return object on snapshot watching. This is needed to unsubscribe

  crwilcox

  committed
  92e98d7

  Copy full SHA for 92e98d7

• Merge branch 'master' into firestore-watch

  crwilcox

  committed
  cf52f51

  Copy full SHA for cf52f51

Commits on Sep 20, 2018

• Remove use of deprecated assert

  crwilcox

  committed
  213169e

  Copy full SHA for 213169e

• Fix bug in deletion of document from map (using wrong key)

  crwilcox

  committed
  abd5c97

  Copy full SHA for abd5c97

Commits on Sep 28, 2018

• startings of ordering

  crwilcox

  committed
  3ed821e

  Copy full SHA for 3ed821e

Commits on Oct 6, 2018

• update tests

  crwilcox

  committed
  2f3cbc7

  Copy full SHA for 2f3cbc7

Commits on Oct 8, 2018

• complete implementation of order

  crwilcox

  committed
  9290511

  Copy full SHA for 9290511

• remove commented code areas in order

  crwilcox

  committed
  f5734e9

  Copy full SHA for f5734e9

• refactor order

  crwilcox

  committed
  78a62a6

  Copy full SHA for 78a62a6

• refactor order compare_objects

  crwilcox

  committed
  925495c

  Copy full SHA for 925495c

• add system test for ordering (currently failing for non-ordering

  crwilcox

  committed
  4316fd1

  Copy full SHA for 4316fd1

Commits on Oct 10, 2018

• add system test for query and verify order

  crwilcox

  committed
  220ba99

  Copy full SHA for 220ba99

• Improve test for order

  crwilcox

  committed
  30972d9

  Copy full SHA for 30972d9

• Add comparator to kw creation of dummyquery, fix old test, move comparator to internal

  crwilcox

  committed
  d549145

  Copy full SHA for d549145

• flake8 fixes

  crwilcox

  committed
  1abc70d

  Copy full SHA for 1abc70d

• coverage + tests

  crwilcox

  committed
  ab862d7

  Copy full SHA for ab862d7

Commits on Oct 11, 2018

• Properly decode document snapshot data and fix tests

  crwilcox

  committed
  be3584f

  Copy full SHA for be3584f

• coverage

  crwilcox

  committed
  abdfe40

  Copy full SHA for abdfe40

• noxfile from master

  crwilcox

  committed
  2af7db7

  Copy full SHA for 2af7db7

• Merge branch 'master' into firestore-watch

  crwilcox

  committed
  a11f8eb

  Copy full SHA for a11f8eb

• Delete Untitled-1

  crwilcox

  authored
  4c52c55

  Copy full SHA for 4c52c55

Commits on Oct 16, 2018

• Merge branch 'master' into firestore-watch

  crwilcox

  committed
  dd9a15f

  Copy full SHA for dd9a15f

• modify to use bidi in api-core. one test has started to fail

  crwilcox

  committed
  17cd042

  Copy full SHA for 17cd042

Commits on Oct 18, 2018

• get tests passing (intermittently) on 2.7,3.5,3.6

  mcdonc

  committed
  f1d079d

  Copy full SHA for f1d079d

Commits on Oct 19, 2018

• fix failing test_order tests when left and right were dictionaries of differing sizes (groups\[61\] vs groups\[62\])

  mcdonc

  committed
  e0cbda4

  Copy full SHA for e0cbda4

• groundwork for firestore

  crwilcox

  committed
  fb8142c

  Copy full SHA for fb8142c

• Use chemelnucfin sample (pythonification of nodejs) as base

  crwilcox

  committed
  a5dbe62

  Copy full SHA for a5dbe62

• syntactic and style fixes

  crwilcox

  committed
  8a5bd5f

  Copy full SHA for 8a5bd5f

• hold work

  crwilcox

  committed
  e296b22

  Copy full SHA for e296b22

• use helper for_document

  crwilcox

  committed
  9499c89

  Copy full SHA for 9499c89

• Staging changes to firestore for watch. still incomplete but returning document changes

  crwilcox

  committed
  e9855fd

  Copy full SHA for e9855fd

• returning watch result now

  crwilcox

  committed
  82a4a06

  Copy full SHA for 82a4a06

• broken currently, but nearing handling of multiple documents in collection

  crwilcox

  committed
  a83ebde

  Copy full SHA for a83ebde

• small fixes. seems mostly working

  crwilcox

  committed
  1d1be53

  Copy full SHA for 1d1be53

• fix variable name, remove things from doc map on remove

  crwilcox

  committed
  80c6bea

  Copy full SHA for 80c6bea

• improve doc strings and comment out yet to be done methods

  crwilcox

  committed
  799fac9

  Copy full SHA for 799fac9

• remove fstrings for 2.7 compat

  

  mcdonc

  authored and

  crwilcox

  committed
  77eea6a

  Copy full SHA for 77eea6a

• be more specific on snapshot type

  crwilcox

  committed
  0db6a9d

  Copy full SHA for 0db6a9d

• unit tests for watch module

  

  mcdonc

  authored and

  crwilcox

  committed
  374775b

  Copy full SHA for 374775b

• these must be staticmethods; improve performance in _affects_target

  

  mcdonc

  authored and

  crwilcox

  committed
  36e431b

  Copy full SHA for 36e431b

• make system test for watch pass

  

  mcdonc

  authored and

  crwilcox

  committed
  4f08ac3

  Copy full SHA for 4f08ac3

• containment check instead of iteration

  

  mcdonc

  authored and

  crwilcox

  committed
  d0bffa9

  Copy full SHA for d0bffa9

• fix filter update test

  

  mcdonc

  authored and

  crwilcox

  committed
  3de5310

  Copy full SHA for 3de5310

• tests for various helper methods

  

  mcdonc

  authored and

  crwilcox

  committed
  40e8b0b

  Copy full SHA for 40e8b0b

• Improve rpc_done and add early query support

  crwilcox

  committed
  1853297

  Copy full SHA for 1853297

• add more tests

  

  mcdonc

  authored and

  crwilcox

  committed
  1e77943

  Copy full SHA for 1e77943

• add tests for close

  

  mcdonc

  authored and

  crwilcox

  committed
  2724132

  Copy full SHA for 2724132

• not reraising in except broke tests

  

  mcdonc

  authored and

  crwilcox

  committed
  d7258c8

  Copy full SHA for d7258c8

• compute_snapshot_ordering test still fails but fails later than it used to

  

  mcdonc

  authored and

  crwilcox

  committed
  1396b74

  Copy full SHA for 1396b74

• remove incorrect comment

  

  mcdonc

  authored and

  crwilcox

  committed
  1465bc2

  Copy full SHA for 1465bc2

• parent is a fq path

  crwilcox

  committed
  39b97db

  Copy full SHA for 39b97db

• fix and add test for _reset_docs

  

  mcdonc

  authored and

  crwilcox

  committed
  39e429f

  Copy full SHA for 39e429f

• undo mistaken push

  

  mcdonc

  authored and

  crwilcox

  committed
  397c6d6

  Copy full SHA for 397c6d6

• appease the linter

  

  mcdonc

  authored and

  crwilcox

  committed
  95a485a

  Copy full SHA for 95a485a

• idiom

  

  mcdonc

  authored and

  crwilcox

  committed
  3424284

  Copy full SHA for 3424284

• enable collection watches

  crwilcox

  committed
  429f86e

  Copy full SHA for 429f86e

• undo spurious changes

  

  mcdonc

  authored and

  crwilcox

  committed
  00de5d3

  Copy full SHA for 00de5d3

• add unfinished test

  

  mcdonc

  authored and

  crwilcox

  committed
  4b96582

  Copy full SHA for 4b96582

• modify the way we compute document references to support query and collection watches

  crwilcox

  committed
  bcecb25

  Copy full SHA for bcecb25

• add system tests for each variety of watch

  crwilcox

  committed
  05db07c

  Copy full SHA for 05db07c

• fix most unit tests, 3 still fail

  

  mcdonc

  authored and

  crwilcox

  committed
  dfaacc7

  Copy full SHA for dfaacc7

• merge and apply

  crwilcox

  committed
  b59b12b

  Copy full SHA for b59b12b

• expected time of test was not the same as read time, so false failure

  crwilcox

  committed
  2a19765

  Copy full SHA for 2a19765

• tests passing

  crwilcox

  committed
  299fd94

  Copy full SHA for 299fd94

• make the datetime.datetime returned non-naive and assume it's in UTC

  

  mcdonc

  authored and

  crwilcox

  committed
  9081664

  Copy full SHA for 9081664

• depends directly on pytz now

  

  mcdonc

  authored and

  crwilcox

  committed
  9489ec1

  Copy full SHA for 9489ec1

• 100pct statement coverage for watch and test_watch

  

  mcdonc

  authored and

  crwilcox

  committed
  be51be8

  Copy full SHA for be51be8

• just cutnpaste this i guess

  

  mcdonc

  authored and

  crwilcox

  committed
  854d051

  Copy full SHA for 854d051

• coverage for collection and bidi modules

  

  mcdonc

  authored and

  crwilcox

  committed
  1059f2c

  Copy full SHA for 1059f2c

• coverage for document and query methods added

  

  mcdonc

  authored and

  crwilcox

  committed
  346e5d6

  Copy full SHA for 346e5d6

• 100 percent branch coverage

  

  mcdonc

  authored and

  crwilcox

  committed
  6cb3e85

  Copy full SHA for 6cb3e85

• appease linter

  

  mcdonc

  authored and

  crwilcox

  committed
  7c73721

  Copy full SHA for 7c73721

• should return object on snapshot watching. This is needed to unsubscribe

  crwilcox

  committed
  7019fd5

  Copy full SHA for 7019fd5

• Fix bug in deletion of document from map (using wrong key)

  crwilcox

  committed
  6f36b6f

  Copy full SHA for 6f36b6f

• startings of ordering

  crwilcox

  committed
  23d467d

  Copy full SHA for 23d467d

• update tests

  crwilcox

  committed
  c8e293a

  Copy full SHA for c8e293a

• complete implementation of order

  crwilcox

  committed
  6cd0ac6

  Copy full SHA for 6cd0ac6

• remove commented code areas in order

  crwilcox

  committed
  41ef649

  Copy full SHA for 41ef649

• refactor order

  crwilcox

  committed
  6be3422

  Copy full SHA for 6be3422

• refactor order compare_objects

  crwilcox

  committed
  b1c42e9

  Copy full SHA for b1c42e9

• add system test for ordering (currently failing for non-ordering

  crwilcox

  committed
  59f725b

  Copy full SHA for 59f725b

• add system test for query and verify order

  crwilcox

  committed
  6888e8a

  Copy full SHA for 6888e8a

• Improve test for order

  crwilcox

  committed
  f77616c

  Copy full SHA for f77616c

• Add comparator to kw creation of dummyquery, fix old test, move comparator to internal

  crwilcox

  committed
  cc445f1

  Copy full SHA for cc445f1

• flake8 fixes

  crwilcox

  committed
  85c199b

  Copy full SHA for 85c199b

• coverage + tests

  crwilcox

  committed
  f75a49c

  Copy full SHA for f75a49c

• Properly decode document snapshot data and fix tests

  crwilcox

  committed
  0125c87

  Copy full SHA for 0125c87

• coverage

  crwilcox

  committed
  cdc6594

  Copy full SHA for cdc6594

• noxfile from master

  crwilcox

  committed
  36e8772

  Copy full SHA for 36e8772

• Delete Untitled-1

  crwilcox

  committed
  738d938

  Copy full SHA for 738d938

• modify to use bidi in api-core. one test has started to fail

  crwilcox

  committed
  9c2ff84

  Copy full SHA for 9c2ff84

• get tests passing (intermittently) on 2.7,3.5,3.6

  

  mcdonc

  authored and

  crwilcox

  committed
  3f8e0c8

  Copy full SHA for 3f8e0c8

• fix failing test_order tests when left and right were dictionaries of differing sizes (groups\[61\] vs groups\[62\])

  

  mcdonc

  authored and

  crwilcox

  committed
  4a892a7

  Copy full SHA for 4a892a7

• fix transports layer use in watch

  crwilcox

  committed
  cb74bf7

  Copy full SHA for cb74bf7

• try adding wait before doc setting. System tests failing on CI but not local

  crwilcox

  committed
  d42f8c5

  Copy full SHA for d42f8c5

Commits on Oct 20, 2018

• merge from crwilcox/firestore-watch and fix conflicts

  mcdonc

  committed
  138a6f1

  Copy full SHA for 138a6f1

• linting

  mcdonc

  committed
  3add82d

  Copy full SHA for 3add82d

• make a bit more idiomatic

  mcdonc

  committed
  b484098

  Copy full SHA for b484098

• more idiomatic, and remove special casing of -0.0 and 0.0 in compare_doubles

  mcdonc

  committed
  e14421b

  Copy full SHA for e14421b

Commits on Oct 22, 2018

• lint fixes

  crwilcox

  committed
  e089dac

  Copy full SHA for e089dac

• Merge branch 'firestore-watch' of github.com:mcdonc/google-cloud-python into firestore-watch

  crwilcox

  committed
  6e588f3

  Copy full SHA for 6e588f3

Commits on Oct 26, 2018

• Start using self.close where previously using self._consumer.stop

  crwilcox

  committed
  136a881

  Copy full SHA for 136a881

• lint

  crwilcox

  committed
  195814b

  Copy full SHA for 195814b

Commits on Nov 7, 2018

• clean up comments

  crwilcox

  committed
  34b4da3

  Copy full SHA for 34b4da3

• alias unsubscribe to close

  crwilcox

  committed
  5622f3c

  Copy full SHA for 5622f3c

• move rpc to internal attr

  crwilcox

  committed
  67c9a47

  Copy full SHA for 67c9a47

Commits on Nov 9, 2018

• Merge branch 'master' into firestore-watch

  crwilcox

  authored
  8900be2

  Copy full SHA for 8900be2