Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanner: add support for DML/PDML #6151

Merged
merged 12 commits into from
Oct 8, 2018
Merged

Spanner: add support for DML/PDML #6151

merged 12 commits into from
Oct 8, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 3, 2018

Blocked pending new rollout of back-end feature.

@tseaver
Remove check that txn has mutations before committing.
777c374 
With DML statements, there may be no explicit mutations tracked on
the client side.
@tseaver
Add (failing) systest for 'execute_sql' w/ DML.
974b598
@tseaver
Add 'Transaction.execute_update' method.
359cb83 
Switch the still-failing system test to use it.
@tseaver
Get new systest to 'pass' by forcing only a single insert.
6896717
@tseaver
Add test for 'Transaction.execute_sql' w/ DML.
250564b 
Assert that stats have appropriate row count.
@tseaver
Pass 'seqno' when invoking 'ExecuteSql'/'ExecuteStreamingSql' APIs.
7cb8fc1 
Required for executing multiple DML statements w/in context of one
transaction.

Update system tests for DML to exercise this (they previously passed only
one statement).
@tseaver
Kill off custom _FauxSpannerAPI mock.
90d9d43
@tseaver
Required integration test cases for non-partitioned DML:
d8f6c81 
- Rollback transaction after performing DML.
- Mix DML and batch-style mutations in a single commit.
@tseaver
Return just row count from 'Transaction.execute_update'.
34d5a45 
Also, drop the 'partition' argument to it:  not appropriate to the
usecase.
@tseaver
Add partitioned DML support (#459)
a37f74a 
* Add 'Datatbase.execute_partitioned_dml' method.

* Add system test which exercises PDML. both for UPDATE (with parameter)
  and DELETE.
@tseaver
Review comment: s/SQL DML/DML/.
7660f40
@tseaver
Review comment: PDML does not support query mode.
d8a714d
@tseaver tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. api: spanner Issues related to the Spanner API. labels Oct 3, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Oct 3, 2018

/cc @snehashah16

@tseaver tseaver removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Oct 8, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Oct 8, 2018

DML / PDML system tests are passing for non-whitelisted projects. Merging and preparing release, per @snehashah16.

@tseaver tseaver merged commit c8bda0f into master Oct 8, 2018
@tseaver tseaver deleted the spanner-dml-prep_for_public branch October 8, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes Awaiting requested review from theacodes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tseaver @googlebot