Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: ensure that 'method' for 'Blob.generate_signed_url' is uppercase. #6110

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Storage: ensure that 'method' for 'Blob.generate_signed_url' is uppercase. #6110

merged 1 commit into from
Sep 26, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 26, 2018

Closes #6107.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label Sep 26, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2018
frankyn
frankyn approved these changes Sep 26, 2018
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit 8671f26 into master Sep 26, 2018
@tseaver tseaver deleted the 6107-storage-create_signed_url-fix_method_case branch September 26, 2018 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@theacodes theacodes Awaiting requested review from theacodes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @frankyn @googlebot