Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw an error if content_type is not set. #6030

Closed
wants to merge 1 commit into from
Closed

Don't throw an error if content_type is not set. #6030

wants to merge 1 commit into from

Conversation

rasmi
Copy link

@rasmi rasmi commented Sep 19, 2018

Fixes #5834.
Content-type is no longer required by the GCS API and defaults to application/octet-stream if not specified.
See: googleapis/nodejs-storage#166 (comment)

@rasmi
Don't throw an error if content_type is not set.
1c4b264 
Content-type is no longer required by the GCS API and defaults to application/octet-stream if not specified.
See: googleapis/nodejs-storage#166 (comment)
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 19, 2018
@tseaver
Copy link
Contributor

tseaver commented Sep 19, 2018

@rasmi Thanks for the fix! It needs a unit test fixups, too. Fortunately, I actually submitted a #6031 with the same change, but unit tests fixed up and a new system test.

@tseaver tseaver closed this Sep 19, 2018
@rasmi
Copy link
Author

rasmi commented Sep 19, 2018

Great, thank you!

@rasmi rasmi deleted the patch-1 branch September 19, 2018 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes Awaiting requested review from theacodes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rasmi @tseaver @googlebot