Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: Add Client.insert_rows, deprecate Client.create_rows #4657

Merged
merged 4 commits into from
Jan 2, 2018

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Dec 22, 2017

insert_rows aligns better with API request (Tabledata.insertAll). Feedback from BQ GA review.

Note that the create_rows() sample in the Python migration guide already points to a commit hash, so this should be safe to merge whenever.

`insert_rows` aligns better with API request (Tabledata.insertAll).
Feedback from BQ GA review.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 22, 2017
@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Jan 2, 2018
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast merged commit 55df6a2 into googleapis:master Jan 2, 2018
@tswast tswast deleted the bq-insert-rows branch January 2, 2018 19:15
body, table, job_config=job_config).result()

df = Config.CLIENT.list_rows(
table, selected_fields=schema).to_dataframe()

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

to_delete.insert(0, table_ref)
# Load a table using a local JSON file from memory.
client.load_table_from_file(
body, table_ref, job_config=job_config).result()

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants