-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigQuery: Add Client.insert_rows, deprecate Client.create_rows #4657
Conversation
`insert_rows` aligns better with API request (Tabledata.insertAll). Feedback from BQ GA review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
body, table, job_config=job_config).result() | ||
|
||
df = Config.CLIENT.list_rows( | ||
table, selected_fields=schema).to_dataframe() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
to_delete.insert(0, table_ref) | ||
# Load a table using a local JSON file from memory. | ||
client.load_table_from_file( | ||
body, table_ref, job_config=job_config).result() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
insert_rows
aligns better with API request (Tabledata.insertAll). Feedback from BQ GA review.Note that the
create_rows()
sample in the Python migration guide already points to a commit hash, so this should be safe to merge whenever.