Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a Consumer.active property to Pub / Sub. #4604

Merged
merged 1 commit into from
Dec 16, 2017
Merged

Adding a Consumer.active property to Pub / Sub. #4604

merged 1 commit into from
Dec 16, 2017

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 15, 2017

NOTE: Has #4603 as diffbase.

I think the function call overhead is worth the trade-off of a "clean" surface (i.e. we could swap out Consumer for a multiprocessing implementation if need be).

@dhermes dhermes added api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern. labels Dec 15, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2017
@dhermes dhermes merged commit 5cc4582 into googleapis:master Dec 16, 2017
@dhermes dhermes deleted the active-property branch December 16, 2017 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

@theacodes theacodes

Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhermes @theacodes @lukesneeringer @tseaver @googlebot