Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown executor when closing Pub/Sub subscriber policy. #4522

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Shutdown executor when closing Pub/Sub subscriber policy. #4522

merged 1 commit into from
Dec 4, 2017

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 4, 2017

No description provided.

@dhermes dhermes added the api: pubsub Issues related to the Pub/Sub API. label Dec 4, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2017
@dhermes dhermes merged commit 22a5a4a into googleapis:master Dec 4, 2017
@dhermes dhermes deleted the pubsub-executor-shutdown branch December 4, 2017 18:40
@dhermes
Copy link
Contributor Author

dhermes commented Dec 4, 2017

I have a feeling that the executor may be a source of a spike in CPU and/or memory usage, but I'm not entirely sure how.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhermes @theacodes @lukesneeringer @tseaver @googlebot