Bugfix: Using max
where min
was used by mistake to ensure a value is non-negative
#4514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intent was to keep
bytes
at or above0
butmin([-n, 0]) == -n
and more importantlymin([n, 0]) = 0
so thatbytes
would be artificially dropped to0
whendrop()
is called.FWIW I was worried this was a data race issue, but I'm fairly certain it isn't. If in fact it turns out to be, we can add a no-op lock class on
base.BasePolicy
and then define
_LOCK_TYPE = threading.Lock
on our concrete implementation and useself._bytes_lock
whenever modifyingPolicy().bytes
.Fixes #4516.