Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubSub: Don't throw exception to python interpreter. #4445

Closed
wants to merge 1 commit into from

Conversation

shileiyu
Copy link

Avoiding annoying traceback.

Don't throw exception to python interpreter.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 23, 2017
@dhermes dhermes added the api: pubsub Issues related to the Pub/Sub API. label Nov 23, 2017
@dhermes
Copy link
Contributor

dhermes commented Nov 23, 2017

@shileiyu Thanks for sending this PR, could you expound a little bit on what problem this solves? I.e. could you provide a code snippet that causes the "annoying traceback" you refer to and then show the equivalent code snippet after this change?

@chemelnucfin chemelnucfin changed the title Don't throw exception to python interpreter. PubSub: Don't throw exception to python interpreter. Nov 23, 2017
@dhermes
Copy link
Contributor

dhermes commented Nov 28, 2017

@shileiyu Thanks for taking the time to write and send this PR.

However, this issue is being resolve in a slightly different manner in #4472. Cheers!

@shileiyu
Copy link
Author

@googlebot I signed it!

@shileiyu shileiyu deleted the patch-1 branch November 29, 2017 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants