Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating some storage mocks after google-resumable-media==0.3.1 release. #4244

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Updating some storage mocks after google-resumable-media==0.3.1 release. #4244

merged 1 commit into from
Oct 25, 2017

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Oct 23, 2017

Fixes #4243.

Also increasing the lower-bound on google-resumable-media to 0.3.1.

@dhermes
Updating some storage mocks after google-resumable-media==0.3.1 rel…
90fd85f 
…ease.

Fixes googleapis#4243.

Also increasing the lower-bound on `google-resumable-media` to `0.3.1`.
@dhermes dhermes added api: storage Issues related to the Cloud Storage API. packaging testing labels Oct 23, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2017
@dhermes
Copy link
Contributor Author

dhermes commented Oct 25, 2017

Can I get a review @jonparrott @tseaver @lukesneeringer? Our tests are broken right meow (e.g. https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/3882)

tseaver
tseaver reviewed Oct 25, 2017
View reviewed changes
storage/tests/unit/test_blob.py
response.raw = io.BytesIO(content)
raw = io.BytesIO(content)
raw.headers = headers
response.raw = raw

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Oct 25, 2017

I'm OK with merging now to unblock others, but I'm worried that we are papering over the real bug (either here or in google-resumable-media). So we should either not close #4243 (but maybe edit its title / description), or else reopen googleapis/google-resumable-media-python#41.

@dhermes
Copy link
Contributor Author

dhermes commented Oct 25, 2017

@tseaver There is no bug. This is working as "intended", but the intent can be discussed (see my comment #4244 (comment))

@dhermes dhermes merged commit 99db799 into googleapis:master Oct 25, 2017
@dhermes dhermes deleted the fix-4243 branch October 25, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees

@lukesneeringer lukesneeringer

@tseaver tseaver

Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. packaging testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhermes @tseaver @lukesneeringer @googlebot