Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'user_project' support to BucketNotification API methods. #4176

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Add 'user_project' support to BucketNotification API methods. #4176

merged 1 commit into from
Oct 13, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 12, 2017

Closes #4150.

@tseaver tseaver added api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 12, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 12, 2017
dhermes
dhermes approved these changes Oct 12, 2017
View reviewed changes
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

storage/tests/unit/test_notification.py
def _make_bucket(self, client, name=BUCKET_NAME):
bucket = mock.Mock(spec=['client', 'name'])
def _make_bucket(self, client, name=BUCKET_NAME, user_project=None):
bucket = mock.Mock(spec=['client', 'name', 'user_project'])

This comment was marked as spam.

Sign in to view

@tseaver tseaver merged commit 3286ae4 into googleapis:master Oct 13, 2017
@tseaver tseaver deleted the 4150-storage-notification-user_project branch October 13, 2017 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot