Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix list_value indexed #399

Merged
merged 6 commits into from
Dec 7, 2014
Merged

fix list_value indexed #399

merged 6 commits into from
Dec 7, 2014

Conversation

lucemia
Copy link
Contributor

@lucemia lucemia commented Dec 2, 2014

for issue: #398

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) when pulling c9846a7 on lucemia:bug-list-value-indexed into 3b90004 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Dec 2, 2014

Thanks for the patch. It needs to add a test covering the case in question.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 01714b2 on lucemia:bug-list-value-indexed into 3b90004 on GoogleCloudPlatform:master.

dhermes
dhermes reviewed Dec 2, 2014
View reviewed changes
gcloud/datastore/connection.py
if not isinstance(value, list):
prop.value.indexed = False

for sub_value in prop.value.list_value:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@lucemia lucemia mentioned this pull request Dec 3, 2014
Closed
@lucemia
Copy link
Contributor Author

lucemia commented Dec 6, 2014

@tseaver great comment, i did the fix.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 22163ff on lucemia:bug-list-value-indexed into ef50cc7 on GoogleCloudPlatform:master.

tseaver added a commit that referenced this pull request Dec 7, 2014
@tseaver
Merge pull request #399 from lucemia/bug-list-value-indexed
a987a43 
fix list_value indexed
@tseaver tseaver merged commit a987a43 into googleapis:master Dec 7, 2014
@tseaver
Copy link
Contributor

tseaver commented Dec 7, 2014

Thanks!

@dhermes dhermes mentioned this pull request Dec 30, 2014
Closed
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
atulep pushed a commit that referenced this pull request Apr 3, 2023
@gcf-owl-bot
chore: use gapic-generator-python 1.0.0 (#399)
5d396fa 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 451250442

Source-Link: googleapis/googleapis@cca5e81

Source-Link: googleapis/googleapis-gen@0b219da
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot
chore: use gapic-generator-python 1.0.0 (#399)
1ab9169 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 451250442

Source-Link: googleapis/googleapis@cca5e81

Source-Link: googleapis/googleapis-gen@0b219da
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot
chore: use gapic-generator-python 1.0.0 (#399)
9e26133 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 451250442

Source-Link: googleapis/googleapis@cca5e81

Source-Link: googleapis/googleapis-gen@0b219da
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
atulep pushed a commit that referenced this pull request Apr 18, 2023
@gcf-owl-bot
chore: use gapic-generator-python 1.0.0 (#399)
0d5048f 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 451250442

Source-Link: googleapis/googleapis@cca5e81

Source-Link: googleapis/googleapis-gen@0b219da
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-storage to v2.6.0 (#399)
33b3790
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore: add prerelease nox session (#399)
4ef08ce 
Source-Link: googleapis/synthtool@050953d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:65e656411895bff71cffcae97246966460160028f253c2e45b7a25d805a5b142

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Jun 4, 2023
@parthea
fix(deps): allow protobuf 3.19.5 (#399)
f4d6da1 
* fix(deps): allow protobuf 3.19.5

* explicitly exclude protobuf 4.21.0
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot @vchudnov-g
chore: Update gapic-generator-python to v1.8.5 (#399)
a4eac86 
* feat: enable "rest" transport in Python for services supporting numeric enums

PiperOrigin-RevId: 508143576

Source-Link: googleapis/googleapis@7a702a9

Source-Link: googleapis/googleapis-gen@6ad1279
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Update gapic-generator-python to v1.8.5

PiperOrigin-RevId: 511892190

Source-Link: googleapis/googleapis@a45d9c0

Source-Link: googleapis/googleapis-gen@1907294
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Victor Chudnovsky <[email protected]>
parthea pushed a commit that referenced this pull request Jul 6, 2023
@dizcology @gcf-owl-bot
chore: copy version from setup.py to google/cloud/language/gapic_vers…
a383dd9 
…ion.py (#399)

* Update gapic_version.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update release-please.yml

* update .release-please-manifest.json version

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Aug 15, 2023
@parthea
chore: test minimum dependencies in python 3.7 (#399)
80f6157
parthea pushed a commit that referenced this pull request Sep 20, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.2.2 (#399)
97cdaca
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@release-please
chore: release 2.8.1 (#399)
bb562f2 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.8.1](https://www.github.com/googleapis/python-dialogflow/compare/v2.8.0...v2.8.1) (2021-09-29)


### Bug Fixes

* add 'dict' annotation type to 'request' ([12b4f60](https://www.github.com/googleapis/python-dialogflow/commit/12b4f6050d0b5f741f106798643bef6ebbbe1e28))

---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-bigquery-datatransfer to …
8387668 
…v3.7.2 (#399)
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: [autoapprove] Pin flake8 version (#399)
8951179 
Source-Link: https://togithub.com/googleapis/synthtool/commit/0ddbff8012e47cde4462fe3f9feab01fbc4cdfd6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update all dependencies (#399)
af9ead1
parthea added a commit that referenced this pull request Sep 22, 2023
@parthea
chore: test minimum dependencies in python 3.7 (#399)
4b7c326
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore(main): release 2.10.1 (#399)
2704618 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-bigquery to v3 (#399)
9d3c21e
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): upgrade gcp-releasetool in .kokoro [autoapprove] (#399)
4ba9aa8 
Source-Link: https://togithub.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: [autoapprove] Update black and isort to latest versions (#399
b5d3bae 
)

Source-Link: https://togithub.com/googleapis/synthtool/commit/0c7b0333f44b2b7075447f43a121a12d15a7b76a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:08e34975760f002746b1d8c86fdc90660be45945ee6d9db914d1508acdf9a547
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.11.2 (#399)
c93eb76 
* chore: Update gapic-generator-python to v1.11.2

PiperOrigin-RevId: 546510849

Source-Link: googleapis/googleapis@736073a

Source-Link: googleapis/googleapis-gen@deb64e8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGViNjRlOGVjMTlkMTQxZTMxMDg5ZmU5MzJiM2E5OTdhZDU0MWM0ZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@parthea
chore: test minimum dependencies in python 3.7 (#399)
398d8e6
parthea pushed a commit that referenced this pull request Oct 21, 2023
@meredithslota
chore(docs): remove samples (#399)
6d5db2e 
* chore(docs): remove samples

Samples have migrated to https://github.com/GoogleCloudPlatform/python-docs-samples/tree/main/cloudbuild/snippets

* chore(docs): remove AUTHORING_GUIDE as obsolete

* chore(docs): remove CONTRIBUTING guide (samples) as obsolete
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
chore: use gapic-generator-python 1.0.0 (#399)
421054a 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 451250442

Source-Link: googleapis/googleapis@cca5e81

Source-Link: googleapis/googleapis-gen@0b219da
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucemia @coveralls @tseaver @dhermes