Spanner: Add a .one and .one_or_none method. #3784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
lukesneeringer
added
api: spanner
|
This seems sane to me. |
tseaver
added
the
do not merge
|
The surface looks fine to me. |
|
cc @mcurtiss |
|
Okay, I will whip up tests. |
googlebot
added
the
cla: yes
lukesneeringer
removed
the
do not merge
|
@jonparrott @tseaver Requesting a review. |
theacodes
approved these changes
Aug 11, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tseaver @jonparrott @vkedia This is a proposal that fixes #3021. I have not implemented tests yet because I want feedback on the surface first.
I basically followed the SQLAlchemy model; the iterator that comes back gets a
.one()and.one_or_none()method, in lieu of aread_row()method onDatabaseobjects (although it would be easy to implement one and have it call this).Essentially, where a developer calls
.read()now, he or she could call.read().one()and get the single-result behavior.If this is workable, then I will write tests.