Move '_catch_remap_gax_error' to 'core.exceptions'. #3444

tseaver · 2017-05-19T19:42:07Z

Toward #3175.

This is the first step toward applying a more uniform mapping of GAX error codes to our exception hierarchy. For a narrower, pubsub-only fix for #3175, see #3443.

Toward #3175.

core/google/cloud/exceptions.py

    _Rendezvous = None
+else:
+    _HAVE_GRPC = True


core/google/cloud/exceptions.py

@@ -250,3 +259,44 @@ def _walk_subclasses(klass):
    code = getattr(_eklass, 'code', None)
    if code is not None:
        _HTTP_CODE_TO_EXCEPTION[code] = _eklass
+
+_GRPC_ERROR_MAPPING = {


core/google/cloud/exceptions.py

+
+
+@contextlib.contextmanager
+def _catch_remap_gax_error():


core/setup.py

@@ -56,6 +56,7 @@
    'protobuf >= 3.0.0',
    'google-auth >= 0.4.0, < 2.0.0dev',
    'google-auth-httplib2',
+    'google-gax>=0.15.7, <0.16dev',


core/tests/unit/test_exceptions.py

@@ -14,6 +14,8 @@

 import unittest

+from google.cloud.exceptions import _HAVE_GRPC


We depend on explicitly in core.

'core' now depends on it explicitly.

Addresses: #3444 (comment)

dhermes · 2017-06-05T18:56:22Z

@lukesneeringer Are you good with the dependency changes?

tseaver · 2017-06-05T19:38:38Z

Note that this change will require releasing a new version of google-cloud-core before / with updated API libraries which use the new google.cloud.exceptions._catch_remap_gax_error. It would obsolete #3443 (which is fine by me).

dhermes · 2017-06-05T19:40:57Z

👍 on the release (I think @lukesneeringer is somewhat anti to the idea of google-cloud-core churn)

tseaver · 2017-06-07T18:24:16Z

@dhermes was there another new core feature / fix you thought would land soon? Right now, I see three other PRs touching core since the core-0.24.1 release:

Adding optional switch to capture project ID in from_service_account_json(). #3436 (forward-compatible feature)
Vision semi-GAPIC #3373 (docs only)
iam.Policy: return empty set on missing key. #3424 (forward-compatible default change)

dhermes · 2017-06-07T19:41:25Z

#3436 was what I was talking about. Looks like we've hit 24 hours, so LGTM?

tseaver · 2017-06-07T20:16:07Z

@dhermes this PR wasn't in the penalty box :). I'm fine to merge today unless @lukesneeringer has issues with us pushing a new core release to support the subsequent API-specific remapping work.

lukesneeringer · 2017-06-14T20:53:46Z

Is the core change backwards-compatible (from an API surface standpoint), or is it something where every single subpackage has to be updated?

I do not mind churn on core; back-incompat churn where everything has to move along with it makes me nervous.

tseaver · 2017-06-14T21:05:59Z

@lukesneeringer the API surface changes are backward-compatible (the add a new, non-API helper function), but the dependency changes are maybe problematic (google-gax becomes an unconditional requirement for core).

lukesneeringer · 2017-06-14T21:08:04Z

That is a smidge concerning. It would mean that APIs based on HTTP only would now require the installation of (but not use of) GRPC.

Would it be possible to only do the mapping if GAX was present, but not require it? (e.g. try / except ImportError)

tseaver · 2017-06-14T21:34:55Z

That is a smidge concerning. It would mean that APIs based on HTTP only would now require the installation of (but not use of) GRPC.

We already have this for "dual mode" APIs: even on "classic" GAE they install grpc / gax.

Would it be possible to only do the mapping if GAX was present, but not require it? (e.g. try / except ImportError)

We can indeed revert to doing that: this PR actually backs that stuff out.

theacodes · 2017-07-17T20:20:18Z

I vote with Luke - can we do this in a way that doesn't require gRPC in core (for now)? I would really like to have this so I can move #3617 forward.

tseaver · 2017-07-31T20:34:48Z

Redoing this on a new branch (recent core changes make me leery of messing up the original one).

tseaver · 2017-07-31T20:37:14Z

Reworked in #3707.

tseaver added api: datastore Issues related to the Datastore API. api: core gax labels May 19, 2017

tseaver requested review from lukesneeringer and dhermes May 19, 2017 19:42

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2017

Move '_catch_remap_gax_error' to 'core.exceptions'.

dfd5ecf

Toward #3175.

dhermes reviewed May 19, 2017

View reviewed changes

tseaver added 3 commits May 19, 2017 17:16

Remove conditional imports of GAX/gRPC-related modules.

69a8fb7

We depend on explicitly in core.

Remove explicit 'google-gax' dep in non-core subprojects.

2eb6fcc

'core' now depends on it explicitly.

Move '_catch_remap_gax_error()' before end-of-module constants.

457c207

Addresses: #3444 (comment)

tseaver mentioned this pull request Jun 7, 2017

Remap new Gax conflict error code #3443

Merged

tseaver mentioned this pull request Jun 7, 2017

Exception Handling Design #3040

Closed

tseaver closed this Jul 31, 2017

tseaver mentioned this pull request Jul 31, 2017

Move 'datastore.exceptions_catch_remap_gax_error' to 'core.exceptions'. #3707

Closed

tseaver deleted the 3175-remap_gax_errors_uniformly branch August 12, 2017 17:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move '_catch_remap_gax_error' to 'core.exceptions'. #3444

Move '_catch_remap_gax_error' to 'core.exceptions'. #3444

tseaver commented May 19, 2017 •

edited

Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Jun 5, 2017

tseaver commented Jun 5, 2017

dhermes commented Jun 5, 2017

tseaver commented Jun 7, 2017

dhermes commented Jun 7, 2017

tseaver commented Jun 7, 2017

lukesneeringer commented Jun 14, 2017

tseaver commented Jun 14, 2017

lukesneeringer commented Jun 14, 2017

tseaver commented Jun 14, 2017

theacodes commented Jul 17, 2017

tseaver commented Jul 31, 2017

tseaver commented Jul 31, 2017

		@@ -14,6 +14,8 @@

		import unittest

		from google.cloud.exceptions import _HAVE_GRPC

Move '_catch_remap_gax_error' to 'core.exceptions'. #3444

Move '_catch_remap_gax_error' to 'core.exceptions'. #3444

Conversation

tseaver commented May 19, 2017 • edited Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes commented Jun 5, 2017

tseaver commented Jun 5, 2017

dhermes commented Jun 5, 2017

tseaver commented Jun 7, 2017

dhermes commented Jun 7, 2017

tseaver commented Jun 7, 2017

lukesneeringer commented Jun 14, 2017

tseaver commented Jun 14, 2017

lukesneeringer commented Jun 14, 2017

tseaver commented Jun 14, 2017

theacodes commented Jul 17, 2017

tseaver commented Jul 31, 2017

tseaver commented Jul 31, 2017

tseaver commented May 19, 2017 •

edited

Loading