Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass client credentials through to instance / database admin API instances #3326

Merged
merged 1 commit into from
Apr 25, 2017
Merged

Pass client credentials through to instance / database admin API instances #3326

merged 1 commit into from
Apr 25, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 25, 2017 •
edited
Loading

Closes #3070.

@tseaver tseaver added api: spanner Issues related to the Spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. release blocking Required feature/issue must be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 25, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 25, 2017
@tseaver tseaver changed the title Pass client credentials through to instance / database admin API inst… Pass client credentials through to instance / database admin API instances Apr 25, 2017
@tseaver tseaver merged commit b657337 into googleapis:master Apr 25, 2017
@tseaver tseaver deleted the 3070-spanner-pass_explicit_creds_to_api_stubs branch April 25, 2017 19:47
@theacodes theacodes removed the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Apr 25, 2017
dhermes
dhermes reviewed Apr 25, 2017
View reviewed changes
spanner/google/cloud/spanner/client.py
@@ -154,6 +154,7 @@ def instance_admin_api(self):
"""Helper for session-related API calls."""
if self._instance_admin_api is None:
self._instance_admin_api = InstanceAdminClient(
credentials=self.credentials,

This comment was marked as spam.

Sign in to view

@dhermes dhermes mentioned this pull request Apr 27, 2017
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@tseaver
Merge pull request googleapis#3326 from tseaver/3070-spanner-pass_exp…
4a37b62 
…licit_creds_to_api_stubs

Pass client credentials through to instance / database admin API instances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes left review comments

@theacodes theacodes theacodes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. release blocking Required feature/issue must be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @theacodes @dhermes @googlebot