Upgrading versions of GAPIC and gRPC generated libraries. #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
32 tasks
This resolves the google-gax 0.14.* conflict.
dhermes
force-pushed
the
upgrade-gapic-deps
branch
from
fc4d2bf
to
2c743e5
Compare
|
See googleapis/gapic-generator#526, we had another issue with positional vs. keyword args. So I made a commit to defensively use keyword arguments ONLY as keywords. Check out the signatures from the 0.9.x versions we were using (I kept a diff around in case reviewers cared). |
theacodes
approved these changes
Sep 28, 2016
This was referenced Sep 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the
google-gax0.14.* conflict.As a side effect this should finally fix the RTD build breakage.
/cc @bjwatson