Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Bigtable and Datastore autogenerate makefiles. #2452

Merged
merged 1 commit into from
Sep 27, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 27, 2016

In the process, also updating a hardcoded path in make_datastore_grpc.

Also, re-running make generate in each of these introduced small changes to the autogenerated bigtable modules.

(This PR needed due to subpackages moving into their own self-contained folders.)

In the process, also updating a hardcoded path in
make_datastore_grpc.

Also, re-running `make generate` in each of these introduced
small changes to the autogenerated bigtable modules.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 27, 2016
Copy link
Contributor

@daspecster daspecster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straight forward change. LGTM

@dhermes dhermes merged commit fdbd094 into googleapis:master Sep 27, 2016
@dhermes dhermes deleted the update-autogen-makefiles branch September 27, 2016 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. grpc packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants