Move bigtable code into a subpackage #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done via: $ mkdir -p bigtable/google/cloud $ cp google/__init__.py bigtable/google/__init__.py $ git add bigtable/google/__init__.py $ cp google/cloud/__init__.py bigtable/google/cloud/__init__.py $ git add bigtable/google/cloud/__init__.py $ git mv google/cloud/bigtable bigtable/google/cloud/bigtable $ git mv unit_tests/bigtable bigtable/unit_tests
- Adding setup.py, MANIFEST.in, README, .coveragerc and tox.ini
- Adding google-cloud-bigtable as a dependency to the umbrella
package
- Adding the bigtable subdirectory into the list of packages
for verifying the docs
- Incorporating the bigtable subdirectory into the umbrella
coverage report
- Adding the bigtable only tox tests to the Travis config
- Updating the project main README to refer the bigtable
subdirectory
- Renamed bigtable _testing imports (since in a new place)
- Adding {toxinidir}/../core as a dependency for the bigtable
tox config
- Updating the location of the ignored bigtable generated
files both in the `pycodestyle` config in `tox.ini`
and in `run_pylint`
Changed the bigtable test helper import via:
$ git grep -l 'from unit_tests.bigtable._testing import _FakeStub' |
> xargs sed -i s/'from unit_tests.bigtable._testing import _FakeStub'/'from unit_tests._testing import _FakeStub'/g
googlebot
added
the
cla: yes
32 tasks
|
Just occurred to me that I didn't move the system test. |
theacodes
approved these changes
Sep 25, 2016
|
@dhermes Before merging, what did you decide to do about the system tests? |
|
I punted to #2404 on system tests. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2404. See #2367 for a reference point.