Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old docsite app files so it doesn't overwrite on deploy #2178

Merged
merged 2 commits into from
Aug 24, 2016

Conversation

daspecster
Copy link
Contributor

@daspecster daspecster commented Aug 24, 2016

We're accepting docsite updates from gcloud-common now.
Anytime there is an update for the site committed to gcloud-common, their deploy-docs.sh file is run and updates the listed repos.

These files were being copied and overwriting the latest app files that were getting pushed by gcloud-common.

@daspecster daspecster added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. docs labels Aug 24, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2016
@daspecster
Copy link
Contributor Author

@callmehiphop can we force run deploy-docs.sh after this is merged to get the latest again from gcloud-common/site?

@callmehiphop
Copy link

Not sure, would restarting an older Travis job do the trick?

@daspecster
Copy link
Contributor Author

That's what I was going to do, but I thought I'd ask just to make sure.

@dhermes
Copy link
Contributor

dhermes commented Aug 24, 2016

  1. LGTM
  2. Why not just run the script locally?
  3. Can any of the other files go? e.g. the JSON files

@daspecster
Copy link
Contributor Author

  1. 🎉
  2. Good idea!
  3. I'm updating to remove extra html files. I think the rest is required?

@callmehiphop can you confirm that all we need is home.html in the json dir?

@callmehiphop
Copy link

@daspecster Yep!

@daspecster daspecster merged commit cf59650 into googleapis:master Aug 24, 2016
@daspecster
Copy link
Contributor Author

Looks like it all worked! The top nav is working and the side nav collapsed appropriately.

@dhermes dhermes mentioned this pull request Sep 19, 2016
@daspecster daspecster deleted the remove-old-doc-site-files branch January 24, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants