Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding UDF Resources to Queries #2015

Closed
wants to merge 27 commits into from
Closed

Adding UDF Resources to Queries #2015

wants to merge 27 commits into from

Conversation

dwmclary
Copy link
Contributor

The BigQuery client doesn't currently support adding UDF resources. This pull request adds a UDFResources object, and properties to set these resources on queries and QueryJobs.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 22, 2016
@dwmclary
Copy link
Contributor Author

dwmclary commented Jul 22, 2016 •
edited
Loading

I signed it!
I'm a Googler.

@dhermes dhermes added the api: bigquery Issues related to the BigQuery API. label Jul 22, 2016
@tseaver
Copy link
Contributor

tseaver commented Jul 22, 2016

See #2007 for an alternative.

@tseaver tseaver mentioned this pull request Jul 22, 2016
Closed
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@dwmclary
Copy link
Contributor Author

All commits were authored by me. I had a different email set as primary when the initial commit was made.

@daspecster
Copy link
Contributor

I'm not entirely sure how that not works but you might have to rebase and
change the user on those commits.

On Friday, July 22, 2016, Daniel McClary [email protected] wrote:

All commits were authored by me. I had a different email set as primary
when the initial commit was made.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#2015 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALvyElSGhqFqGtucoId7um9jqo9fiHlks5qYVB7gaJpZM4JTBqe
.

Tom Schultz

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 23, 2016
@dwmclary
Copy link
Contributor Author

OK rebased to reflect the proper author email.

tseaver
tseaver reviewed Jul 26, 2016
View reviewed changes
gcloud/bigquery/job.py
if not self._udf_resources:
return []
if not all(isinstance(u, UDFResource) for u in self._udf_resources):
raise ValueError("udf items must be UDFResource")

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Jul 26, 2016

@dwmclary Thanks for the patch!

@tseaver tseaver added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jul 26, 2016
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 26, 2016
@tseaver
Copy link
Contributor

tseaver commented Jul 26, 2016

@dwmclary It appears that Github / the CLA bot do not think 1ff3252 was authored by you, but by another blind poet of the same name.

dwmclary and others added 14 commits July 26, 2016 12:47
@dwmclary
fixed last linter warning
e500987
@daspecster @dwmclary
First pass at Python doc generator...(originally JJ's commit)
4a4941c
@daspecster @dwmclary
Initial update to generate json docs
c2ad035 
Testing deploy with 1:1 class:json.

Add overview.html

Deploy script working now in testing.

Fix code blocks.

Add href support.

Add snippets to base service module. closes #1951

Fix types generation.

Fix linking.

Fix external github links.

Update gcloud-commit site files.

Swtich to live site generation.

clean up manifest for starters.

Remove old example detection code.

Update TOC.
@daspecster @dwmclary
Update site and fix typos.
bc584bf
@daspecster @dwmclary
Add RST snippet captions.
11e897f
@daspecster @dwmclary
Remove old gh-pages doc build script.
fbd411b
@daspecster @dwmclary
Switch to using tox for calling json docs update script.
a6b2751
@daspecster @dwmclary
Add Sphinx as a dependency for linting.
35678f6
@daspecster @dwmclary
Exclude verify_included_modules.py from lint.
6ee3826
@dwmclary
Add Error Reporting Client
b9f8a2f
@daspecster @dwmclary
Update gcloud references.
6aa1c57
@dwmclary
response to code review, better tests, no backslashes
897f8c0
@dwmclary
started addding udf resources
1b29095
@dwmclary
coverage fixed
79b38e5
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@dwmclary
Copy link
Contributor Author

Authored by me, and now painfully rebased to reflect it.

@dwmclary
Copy link
Contributor Author

OK, should be all fixed as soon as CLAbot looks at the authorship again.

@dwmclary
Copy link
Contributor Author

@googlebot can you check the CLA again?

@dwmclary
Copy link
Contributor Author

@tseaver @daspecster Any idea why the CLA isn't flipping? At this point all commits and author emails should point to me. There doesn't appear to be any rebase magic I can perform beyond this. Worst-case, I can re-fork and resubmit if we can't make @googlebot behave.

dwmclary added a commit to dwmclary/gcloud-python that referenced this pull request Jul 27, 2016
@dwmclary
refork and fix of googleapis#2015
c8ba881
@dwmclary dwmclary mentioned this pull request Jul 27, 2016
Merged
@dwmclary
Copy link
Contributor Author

Re-opened here

@dwmclary dwmclary closed this Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: no This human has *not* signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dwmclary @googlebot @tseaver @daspecster @dhermes