Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DNS resource_record_set() #1977

Merged
merged 1 commit into from
Jul 12, 2016
Merged

Update DNS resource_record_set() #1977

merged 1 commit into from
Jul 12, 2016

Conversation

daspecster
Copy link
Contributor

I don't get why you need a . after domains though?

Is that something we should do for people? It seems so counterintuitive.

@daspecster daspecster added docs api: dns Issues related to the Cloud DNS API. labels Jul 12, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 12, 2016
@tseaver
Copy link
Contributor

tseaver commented Jul 12, 2016

@daspecster http://www.dns-sd.org/trailingdotsindomainnames.html

@tseaver
Copy link
Contributor

tseaver commented Jul 12, 2016

LGTM

@daspecster
Copy link
Contributor Author

Wow, I did not know that!

@daspecster daspecster merged commit d9220c6 into googleapis:master Jul 12, 2016
@daspecster daspecster deleted the fix-dns-record-set-docs branch July 12, 2016 20:02
This was referenced Aug 3, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tseaver tseaver

Labels
api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daspecster @tseaver @googlebot