Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate code for Bigtable v2 protobufs #1903

Merged
merged 3 commits into from
Jun 26, 2016
Merged

Generate code for Bigtable v2 protobufs #1903

merged 3 commits into from
Jun 26, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 24, 2016 •
edited
Loading

Put V2-generated files them in a separate _generated_v2 subdir, to ease migration.

Attempt to factor generation process for clarity (toward #1482).

Supersedes #1895.

@tseaver
Split 'Makefile' into datastore and bigtable portions.
a43b2eb 
Pass the 'PROTOC_CMD' and 'GRPC_PLUGIN' values through from make's
environment to the scripts used to pick apart GRPC-specific code.
@tseaver
Generate Bigtable V2 protos.
0f4a064 
Put them in a separate '_generated_v2' subdir, to ease migration.

Attempt to factor generation process for clarity (toward #1482).
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2016
@tseaver tseaver changed the title Generate cod for Bigtable v2 protobufs Generate code for Bigtable v2 protobufs Jun 24, 2016
This was referenced Jun 24, 2016
Closed
Closed
@daspecster
Copy link
Contributor

@tseaver & @dhermes is there anything specific I should keep an eye out for with these?

@tseaver
Copy link
Contributor Author

tseaver commented Jun 24, 2016

@daspecster The code in the _generated_v2 package you can ignore. The other changes are attempts to improve how we generated code from protobufs (splitting up the Makefile, etc.)

@daspecster
Copy link
Contributor

Should datastore be in here with bigtable or should that be a separate PR?

@tseaver
Copy link
Contributor Author

tseaver commented Jun 24, 2016

The only thing I did with datastore was to factor its generate-from-protobuf bits into a separate Makefile.datastore. I ran the generation for it, and saw minor changes to the generated code, which I then discarded (not on my radar just now).

@tseaver tseaver mentioned this pull request Jun 26, 2016
Merged
@daspecster
Copy link
Contributor

LGTM!

@tseaver tseaver merged commit e570b03 into googleapis:bigtable-v2 Jun 26, 2016
@tseaver tseaver deleted the bigtable-v2-regenerate_protobufs branch June 26, 2016 20:08
This was referenced Jun 26, 2016
Merged
Closed
Merged
parthea pushed a commit that referenced this pull request Oct 21, 2023
@daniel-sanche @busunkim96
KMS: Updated for new client library [(#1903)](GoogleCloudPlatform/pyt…
620b210 
…hon-docs-samples#1903)

* updated kms samples to use new gapic client library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @daspecster @dhermes @googlebot