Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GAX-based _SubscriberAPI. #1795

Merged
merged 3 commits into from
May 16, 2016
Merged

Add GAX-based _SubscriberAPI. #1795

merged 3 commits into from
May 16, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 13, 2016 •
edited
Loading

Uses #1764 as a base.

@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label May 13, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2016
@tseaver
Copy link
Contributor Author

tseaver commented May 16, 2016

@dhermes rebased after merging #1794 to master. PTAL

dhermes
dhermes reviewed May 16, 2016
View reviewed changes
gcloud/pubsub/_gax.py
"""List subscriptions for the project associated with this API.

See:
https://cloud.google.com/pubsub/reference/rest/v1/projects.subscriptions/list

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented May 16, 2016

LGTM. Please fix the small nits, but don't need to check with me once fixed.

@tseaver tseaver merged commit bb26745 into googleapis:master May 16, 2016
@tseaver tseaver deleted the pubsub-wrap_gax_subscriber_api branch May 16, 2016 15:54
@tseaver tseaver mentioned this pull request May 16, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot