Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid get / set of IAM policy if current account doesn't have permission #1782

Merged
merged 1 commit into from
May 11, 2016
Merged

Avoid get / set of IAM policy if current account doesn't have permission #1782

merged 1 commit into from
May 11, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 6, 2016 •
edited
Loading

Uses #1776 as a base.

Closes #1687.

Closes #1743.

@tseaver tseaver added testing api: pubsub Issues related to the Pub/Sub API. labels May 6, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2016
@tseaver
Copy link
Contributor Author

tseaver commented May 6, 2016

@dhermes PTAL: this PR illustrates using the enumerated pubsub permissions from #1775 in a "look-before-you-leap" way to implement #1743. It also exercises the {Topic,Subscription}check_iam_permissions correctly, as discovered in #1687.

@dhermes
Copy link
Contributor

dhermes commented May 9, 2016

@tseaver Can you ping me once this is rebased?

@tseaver
Copy link
Contributor Author

tseaver commented May 10, 2016

@dhermes rebased against master. PTAL

@dhermes
Copy link
Contributor

dhermes commented May 11, 2016

Sorry for the delay. On it now.

@dhermes
Copy link
Contributor

dhermes commented May 11, 2016

LGTM

@tseaver tseaver merged commit 096b5f6 into googleapis:master May 11, 2016
@tseaver tseaver deleted the 1687-1743-pubsub-iam_system_tests branch May 11, 2016 18:19
@tseaver tseaver mentioned this pull request May 16, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot