Define __all__ in gcloud/monitoring/__init__.py.

[rimey]

This is so that "from gcloud.monitoring import *" doesn't import
the package's module names.

[tseaver]

-0, mostly because from foo import * is a truly evil pattern. I would definitely vote to reject any docs change which showed from gcloud.monitoring import *.

[tseaver]

Looking at the module: there are no names present which are not listed in __all__.

[rimey]

This is a package, so it brings in all the module names: client, connection, label, metric, ...

[rimey]

from gcloud.monitoring import * is useful interactively.

[rimey]

>>> from gcloud import monitoring
>>> client = monitoring.Client('my-project')
>>> q = client.query(hours=2).align(Aligner.ALIGN_MEAN, minutes=5)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'Aligner' is not defined
>>> from gcloud.monitoring import *
>>> q = client.query(hours=2).align(Aligner.ALIGN_MEAN, minutes=5)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'module' object has no attribute 'query'

[dhermes]

I'm fine with defining __all__. But, @jonparrott recently pointed out that imported modules are not considered part of the public API. From PEP8

Imported names should always be considered an implementation detail. Other modules must not rely on indirect access to such imported names unless they are an explicitly documented part of the containing module's API, such as os.path or a package's init module that exposes functionality from submodules.

For an example from the stdlib.

>>> import subprocess
>>> subprocess.sys
<module 'sys' (built-in)>

[jgeewax]

I'm OK with this change -- though I'm -1 to using the import * pattern in our documentation.

If people want to use that interactively that's fine with me, but it's certainly not recommended.

[dhermes]

Shall we merge then? @tseaver any objections?

---

Ditto on that. Namespaces are one of Python's strengths (both in language design and community / "idiomatic" behavior). From the Zen of Python:

Namespaces are one honking great idea -- let's do more of those!

[rimey]

Defining __all__ in this circumstance is standard practice. You just don't see it that much outside of carefully curated libraries like the Python standard library, because it's of minor consequence, for the reasons you have mentioned.

[tseaver]

LGTM