Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid reusing logger name in logging system tests #1677

Merged
merged 1 commit into from
Mar 30, 2016
Merged

Avoid reusing logger name in logging system tests #1677

merged 1 commit into from
Mar 30, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 30, 2016

Fixes order-based failure between 'log_struct' and 'log_test'.
#1657 still breaks the teardown.

@tseaver
Avoid reusing logger name between tests.
660441d 
Fixes order-based failure between 'log_struct' and 'log_test'.

#1657 still breaks the teardown.
@tseaver tseaver added testing api: logging Issues related to the Cloud Logging API. labels Mar 30, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2016
@dhermes
Copy link
Contributor

dhermes commented Mar 30, 2016

LGTM pending Travis

@tseaver tseaver merged commit 9a7df6f into googleapis:logging-api Mar 30, 2016
@tseaver tseaver deleted the logging-system_tests-avoid_reusing_logger_name branch March 30, 2016 17:10
@dhermes dhermes mentioned this pull request Apr 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot