Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit dep on 'sphinx_rtd_theme' for 'tox -e docs'. #1667

Merged
merged 1 commit into from
Mar 28, 2016
Merged

Add explicit dep on 'sphinx_rtd_theme' for 'tox -e docs'. #1667

merged 1 commit into from
Mar 28, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 28, 2016

Sphinx 1.4 dropped the dependency.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Mar 28, 2016

@dhermes unless you object, I will merge this to master and logging-api branches as soon as Travis passes, and then rebase the failing-due-to-Sphinx-1.4 #1665 and #1666.

@tseaver tseaver merged commit 89693ec into googleapis:master Mar 28, 2016
@tseaver tseaver deleted the fix-sphinx-1.4-breakage branch March 28, 2016 16:36
This was referenced Mar 28, 2016
Merged
Merged
@dhermes dhermes mentioned this pull request Apr 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot