Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Bigtable system tests to list of default system tests. #1633

Merged
merged 1 commit into from
Mar 18, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 18, 2016

No description provided.

@dhermes dhermes added testing api: bigtable Issues related to the Bigtable API. labels Mar 18, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 176e0e8 on dhermes:turn-on-bigtable-sys-tests into 49f18ed on GoogleCloudPlatform:master.

tseaver added a commit that referenced this pull request Mar 18, 2016
Adding Bigtable system tests to list of default system tests.
@tseaver tseaver merged commit 5dc0546 into googleapis:master Mar 18, 2016
@dhermes dhermes deleted the turn-on-bigtable-sys-tests branch March 18, 2016 14:24
@dhermes
Copy link
Contributor Author

dhermes commented Mar 18, 2016

@tseaver I'm AFK right now but this is going to be more painful than I thought.

  1. It's failing on the merge commit because it needs grpcio in the tox environment.
  2. It needs to be disabled in Python 3

@tseaver
Copy link
Contributor

tseaver commented Mar 18, 2016

OK, I've reverted it.

@dhermes
Copy link
Contributor Author

dhermes commented Mar 18, 2016

Cool. I think the fix will be a two-liner change to tox.ini since system-tests and system-tests3 are separate it won't be that hard to just run another script in the first env.

@tseaver
Copy link
Contributor

tseaver commented Mar 18, 2016

Does the travis utility script have an option to emulate running tests locally?

@dhermes
Copy link
Contributor Author

dhermes commented Mar 18, 2016

No idea. What's the concern?

@tseaver
Copy link
Contributor

tseaver commented Mar 18, 2016

So that we could exercise all the Travis-dependent bits of our scaffolding. It doesn't look like it.

@dhermes
Copy link
Contributor Author

dhermes commented Mar 18, 2016

The failure of this PR was not Travis based. I never ran it locally (I was in too big a hurry). tox will "save us".

I'd also say that tox -e system-tests is no longer worth running locally. Instead

python system_tests/run_system_test.py --package=FOO

will be better during local dev (since much faster).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants