Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Message.service_timestamp' property. #1627

Merged
merged 1 commit into from
Mar 18, 2016
Merged

Add 'Message.service_timestamp' property. #1627

merged 1 commit into from
Mar 18, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 17, 2016

Set via the back-end set 'publishTimestamp' field in the 'PubsbuMessage' resource.

Fixes #1623.

@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Mar 17, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Mar 17, 2016

ATM, assumes that the answer to my question in #1623 is "no".

instance = cls(
data=data, message_id=api_repr['messageId'],
attributes=api_repr.get('attributes'))
instance._service_timesstamp = api_repr.get('publishTimestamp')

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Mar 18, 2016

LGTM pending rename

Set via the back-end set 'publishTimestamp' field in the 'PubsbuMessage'
resource.

Fixes #1623.
tseaver added a commit that referenced this pull request Mar 18, 2016
…estamp

Add 'Message.service_timestamp' property.
@tseaver tseaver merged commit 72d0bba into googleapis:master Mar 18, 2016
tseaver added a commit that referenced this pull request Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants