Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass mutated properties through to 'bucket.create' API call. #1579

Merged
merged 1 commit into from
Mar 9, 2016
Merged

Pass mutated properties through to 'bucket.create' API call. #1579

merged 1 commit into from
Mar 9, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 7, 2016

Fixes: #1575.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Mar 7, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 7, 2016
@tseaver tseaver mentioned this pull request Mar 7, 2016
Closed
dhermes
dhermes reviewed Mar 8, 2016
View reviewed changes
gcloud/storage/bucket.py
@@ -167,9 +167,12 @@ def create(self, client=None):
"""
client = self._require_client(client)
query_params = {'project': client.project}
properties = dict(
(key, self._properties[key]) for key in self._changes)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Mar 9, 2016

LGTM

tseaver added a commit that referenced this pull request Mar 9, 2016
@tseaver
Merge pull request #1579 from tseaver/1575-bucket_location_at_create
cf581cb 
Pass mutated properties through to 'bucket.create' API call.
@tseaver tseaver merged commit cf581cb into googleapis:master Mar 9, 2016
@tseaver tseaver deleted the 1575-bucket_location_at_create branch March 9, 2016 01:10
@dhermes dhermes mentioned this pull request Apr 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot