Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting Bigtable Row into 3 classes based on the mutation type / RPC method used in commit() #1557

Merged
merged 15 commits into from
Mar 8, 2016
Merged

Splitting Bigtable Row into 3 classes based on the mutation type / RPC method used in commit() #1557

merged 15 commits into from
Mar 8, 2016

Commits on Mar 3, 2016

  1. Splitting Bigtable Row implementation into 3 parts. 

    For now, just renaming Row->DirectRow and creating
2 do-nothing subclasses. Class will be torn down
in subsequent commits.
    @dhermes
    dhermes committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    45980ca View commit details
    Browse the repository at this point in the history

  2. Bigtable: Moving implementation of AppendRow from Row.

    @dhermes
    dhermes committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    a618f8b View commit details
    Browse the repository at this point in the history

  3. Renaming Bigtable Row.clear_mutations()->clear.

    @dhermes
    dhermes committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    de4aa35 View commit details
    Browse the repository at this point in the history

  4. Adding ConditionalRow to Bigtable row factory.

    @dhermes
    dhermes committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    f82be90 View commit details
    Browse the repository at this point in the history

  5. Beginning Bigtable ConditionalRow implementation.

    @dhermes
    dhermes committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    449876f View commit details
    Browse the repository at this point in the history

  6. Re-locating Bitable tests for ConditionalRow.

    @dhermes
    dhermes committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    4d7d660 View commit details
    Browse the repository at this point in the history

  7. Moving _commit_check_and_mutate to ConditionalRow.

    @dhermes
    dhermes committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    67a19d8 View commit details
    Browse the repository at this point in the history

  8. Removing filter_ from Bigtable DirectRow constructor. 

    Simplifying most downstream issues by just removing any
code in DirectRow that branched based on the presence
of filter_.
    @dhermes
    dhermes committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    5dbcd03 View commit details
    Browse the repository at this point in the history

  9. Renaming ConditionalRow._commit_check_and_mutate->commit. 

    Also simplifying DirectRow.commit() in the process.
    @dhermes
    dhermes committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    e7068de View commit details
    Browse the repository at this point in the history

  10. Renaming DirectRow._commit_mutate->commit.

    @dhermes
    dhermes committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    7a003f3 View commit details
    Browse the repository at this point in the history

  11. Removing state argument from DirectRow.set_cell(). 

    Factoring behavior out into a non-public helper _set_cell()
and using that helper in both DirectRow and ConditionalRow.
    @dhermes
    dhermes committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    5a80ad6 View commit details
    Browse the repository at this point in the history

  12. Removing state argument from DirectRow.delete(). 

    Factoring behavior out into a non-public helper _delete()
and using that helper in both DirectRow and ConditionalRow.

Also making sure ConditionalRow.delete() gets tested (codepath
was only previously traversed via the parent class).
    @dhermes
    dhermes committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    bca6f88 View commit details
    Browse the repository at this point in the history

  13. Removing state argument from DirectRow.delete_cell(s). 

    Factoring behavior out into a non-public helper _delete_cells()
and using that helper in both DirectRow and ConditionalRow.

Also making sure ConditionalRow.delete_cell(s) get tested (codepaths
were only previously traversed via the parent class).
    @dhermes
    dhermes committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    33eb483 View commit details
    Browse the repository at this point in the history

  14. Temporary Pylint hack. 

    Long-term fix will be to create the
`gcloud.bigtable.row_filters` module to reduce
the amount of code in `gcloud.bigtable.row`.

Also removing superflous assignment.
    @dhermes
    dhermes committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    eb41d4a View commit details
    Browse the repository at this point in the history

  15. Updating documentation after Row->DirectRow split.

    @dhermes
    dhermes committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    d570aec View commit details
    Browse the repository at this point in the history