Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding GC Rule to Bigtable Column Family class. #1302

Merged
merged 1 commit into from
Dec 17, 2015
Merged

Adding GC Rule to Bigtable Column Family class. #1302

merged 1 commit into from
Dec 17, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Dec 17, 2015

Also adding equality check for column family
instances.

@dhermes
Adding GC Rule to Bigtable Column Family class.
9b296c9 
Also adding equality check for column family
instances.
@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Dec 17, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2015
tseaver
tseaver reviewed Dec 17, 2015
View reviewed changes
gcloud/bigtable/column_family.py
other.gc_rule == self.gc_rule)

def __ne__(self, other):
return not self.__eq__(other)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Dec 17, 2015

LGTM. Maybe we can revisit pulling out the __ne__s later/

dhermes added a commit that referenced this pull request Dec 17, 2015
@dhermes
Merge pull request #1302 from dhermes/bigtable-col-fam-w-gc-rule
ae01c3a 
Adding GC Rule to Bigtable Column Family class.
@dhermes dhermes merged commit ae01c3a into googleapis:master Dec 17, 2015
@dhermes dhermes deleted the bigtable-col-fam-w-gc-rule branch December 17, 2015 19:32
@dhermes
Copy link
Contributor Author

dhermes commented Dec 17, 2015

You're reviewing faster than I can get them out! I'm trying to balance this and grading a final exam, and you're winning.

Care to take a look at #1241 (mine) and #1274 (a very important fix in light of #1214)?

@tseaver
Copy link
Contributor

tseaver commented Dec 17, 2015

No worries. I've got to get my Table.upload_from_file finished.

I'll try to look again at #1241: I had the impression that it was "not ready for prime time."

#1274 worries me.

@dhermes
Copy link
Contributor Author

dhermes commented Dec 17, 2015

#1241 is ready for prime time, I am working on getting it merge-able right now (done, if tests pass).

#1274 worries me too, but so does #1214. Let's continue the discussion in one of those places?

@dhermes dhermes mentioned this pull request Jan 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @tseaver @googlebot