Removing serializable option from datastore Transaction.

[dhermes]

This is in advance of the option being removed in v1beta3. Since in v1beta3:

All transactions are now serializable

we set the isolation to always be serializable.

---

@pcostell Is this "safe" to do as prep for the version upgrade?

Also, is there an equivalent replacement in v1beta3? AFAICT the isolation level is just gone.

[pcostell]

In v1beta3 we opted to only expose serializable which is a stronger form of isolation. I think in v1beta2 if you want to remove the option you need to force it to be set to serializable (the default is snapshot).

Also, I'm not sure if you've seen it, but here are the (whitelisted) release notes: https://cloud.google.com/datastore/v1beta3/release-notes

[tseaver]

LGTM. I never saw the point in snapshot for a transaction, anyhow.

[tseaver]

@pcostell that URL 404s for me.

[pcostell]

Sorry it is behind a whitelist. Can you email me your google account that you use? (@gmail, @google, or other Google Apps domain)

[dhermes]

Thanks @pcostell. Can you also add [email protected]? (I can see it with my corp email, but seldom have corp access.)

---

@tseaver After seeing Patrick's comments and the whitelist, I think it's best to set the isolation level always to serializable.

PTAL

[tseaver]

@pcostell [email protected]

[dhermes]

@tseaver are we LGTM with the update to isolation_level?

[tseaver]

LGTM: setting explicitly in the protobuf makes the behavior forward compatible.

[pcostell]

@dhermes @tseaver -- added your accounts to the whitelist.

[dhermes]

Thanks