Implementing Bigtable Cluster.list_tables(). #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| self.name + '/tables/', 1) | ||
| if before != '': | ||
| raise ValueError('Table name %s not of expected format' % ( | ||
| table_pb.name,)) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This uses the table stub instead of the cluster stub. This method is actually talking to a different service than every method until now. Also implementing Table.__eq__ so table comparison succeeds in unit tests.
dhermes
force-pushed
the
bigtable-list-tables
branch
from
9dc17cc
to
215b9f6
Compare
| result = [] | ||
| for table_pb in table_list_pb.tables: | ||
| table_prefix = self.name + '/tables/' | ||
| if not table_pb.name.startswith(table_prefix): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Dec 5, 2015
Implementing Bigtable Cluster.list_tables().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the table stub instead of the cluster stub. This
method is actually talking to a different service than
every method until now.
Also implementing
Table.__eq__so table comparison succeedsin unit tests.