Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip excess custom exceptions from 'gcloud.streaming' #1232

Merged
merged 7 commits into from
Nov 19, 2015
Merged

Strip excess custom exceptions from 'gcloud.streaming' #1232

merged 7 commits into from
Nov 19, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 19, 2015

Closes #1227

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2015
dhermes
dhermes reviewed Nov 19, 2015
View reviewed changes
gcloud/streaming/transfer.py
@@ -647,11 +643,11 @@ def from_file(cls, filename, mime_type=None, auto_transfer=True, **kwds):
"""
path = os.path.expanduser(filename)
if not os.path.exists(path):
raise NotFoundError('Could not find file %s' % path)
raise ValueError('Could not find file %s' % path)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Nov 19, 2015

This doesn't "move the remainder to gcloud.exceptions" as the bug says will happen.

@tseaver
Copy link
Contributor Author

tseaver commented Nov 19, 2015

The residue are all tangled up with fixing #1223. If there are any left after that one, then they can move.

@dhermes
Copy link
Contributor

dhermes commented Nov 19, 2015

I suggest filing another bug then (or leaving that one open and renaming it) so it doesn't slip our minds.

@tseaver tseaver mentioned this pull request Nov 19, 2015
Closed
@tseaver
Copy link
Contributor Author

tseaver commented Nov 19, 2015

#1234 captures the final cleanup.

@dhermes
Copy link
Contributor

dhermes commented Nov 19, 2015

Good deal

@tseaver
Drop look-before-you-leap check for existing file.
7ddd0b0 
Allow 'natural' OSError to propagate.

Addresses:

#1232 (comment)
@dhermes
Copy link
Contributor

dhermes commented Nov 19, 2015

LGTM pending Travis

tseaver added a commit that referenced this pull request Nov 19, 2015
@tseaver
Merge pull request #1232 from tseaver/1227-streaming-strip_excess_cus…
cec15ac 
…tom_exceptions

Strip excess custom exceptions from 'gcloud.streaming'
@tseaver tseaver merged commit cec15ac into googleapis:master Nov 19, 2015
@tseaver tseaver deleted the 1227-streaming-strip_excess_custom_exceptions branch November 19, 2015 23:11
@dhermes dhermes mentioned this pull request Jan 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot