Speling: pass 'ack_deadline' as 'ackDeadlineSeconds' everywhere.

[tseaver]

May fix #1169.

[dhermes]

Can you update the system tests to avoid this issue coming up again?

Also, can you link to a doc describing this parameter.

[tseaver]

Can you update the system tests to avoid this issue coming up again?

I guess I could: we don't have anything like exhaustive coverage in the system tests, though.

Also, can you link to a doc describing this parameter.

https://cloud.google.com/pubsub/reference/rest/v1/projects.subscriptions#Subscription.FIELDS.ack_deadline_seconds

(note the irony that the ID for the table cell is closer to our spelling than to the one used in the actual API).

[dhermes]

I think the reason our system tests were ever named regression tests was for reasons like the very bug that caused this.

Let's add one to make sure it doesn't come back.

---

How could we be more comprehensive? Should we?

[tseaver]

Let's add one to make sure it doesn't come back.

543caaf adds that test.

How could we be more comprehensive? Should we?

Dunno: for instance, the other optional parameter to Subscription.create() is push_endpint, but we won't be able to exercise it without having an actual, approved URL.

[dhermes]

Great! LGTM

(We have similar issues with Bigtable)