Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for resource record sets #1144

Merged
merged 4 commits into from
Sep 21, 2015
Merged

Add support for resource record sets #1144

merged 4 commits into from
Sep 21, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 21, 2015

No description provided.

@tseaver tseaver added the api: dns Issues related to the Cloud DNS API. label Sep 21, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2015
@@ -104,23 +104,23 @@ Each managed zone exposes a read-only set of resource records:
>>> from gcloud import dns
>>> client = dns.Client(project='PROJECT_ID')
>>> zone = client.zone('acme-co')
>>> records, page_token = zone.list_resources() # API request
>>> records, page_token = zone.list_resource_record_sets() # API request

This comment was marked as spam.

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Sep 21, 2015

LGTM

You know I'm always on the fence about if KeyError is sufficient enough explanation to the user of why the backend is lying to us and them, but I'm on the LGTM side of the fence today, proceed.

tseaver added a commit that referenced this pull request Sep 21, 2015
@tseaver tseaver merged commit c4602c3 into googleapis:master Sep 21, 2015
@tseaver tseaver deleted the dns-resource_record_sets branch September 21, 2015 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants